Merge pull request #16473 from hvitved/csharp/entity-framework-perf

C#: Fix performance issue in EntityFramework modelling

Author: hvitved

csharp/ql/lib/semmle/code/csharp/frameworks/EntityFramework.qll

@@ -437,26 +437,21 @@ module EntityFramework {
     ) {
       this = dbSet.getDbContextClass() and
       this.output(output, mapped, dbSet) and
-      result = dbSet.getFullName() + "#" + output.getMadRepresentation()
+      exists(string qualifier, string type, string name |
+        mapped.hasFullyQualifiedName(qualifier, type, name) and
+        result = getQualifiedName(qualifier, type, name)
+      )
     }
+
+    pragma[nomagic]
+    string getSyntheticNameProj(Property mapped) { result = this.getSyntheticName(_, mapped, _) }
   }
 
   private class DbContextClassSetProperty extends Property {
     private DbContextClass c;
 
     DbContextClassSetProperty() { this = c.getADbSetProperty(_) }
 
-    /**
-     * Gets the fully qualified name for this.
-     */
-    string getFullName() {
-      exists(string qualifier, string type, string name |
-        this.hasFullyQualifiedName(qualifier, type, name)
-      |
-        result = getQualifiedName(qualifier, type, name)
-      )
-    }
-
     /**
      * Gets the context class where this is a DbSet property.
      */
@@ -493,7 +488,7 @@ module EntityFramework {
       exists(string name, Property mapped |
         preservesValue = true and
         c.input(input, mapped) and
-        name = c.getSyntheticName(_, mapped, _) and
+        name = c.getSyntheticNameProj(mapped) and
         output = SummaryComponentStack::syntheticGlobal(name) and
         model = "DbContextSaveChanges"
       )
@@ -504,7 +499,7 @@ module EntityFramework {
    * Add all possible synthetic global names.
    */
   private class EFSummarizedCallableSyntheticGlobal extends SummaryComponent::SyntheticGlobal {
-    EFSummarizedCallableSyntheticGlobal() { this = any(DbContextClass c).getSyntheticName(_, _, _) }
+    EFSummarizedCallableSyntheticGlobal() { this = any(DbContextClass c).getSyntheticNameProj(_) }
   }
 
   private class DbContextSaveChangesRequiredSummaryComponentStack extends RequiredSummaryComponentStack