Ruby: move string getAQualifiedName() up to ConstantAccess

Author: alexrford

ruby/ql/lib/codeql/ruby/ast/Constant.qll

@@ -208,6 +208,11 @@ class ConstantAccess extends Expr, TConstantAccess {
    */
   predicate hasGlobalScope() { none() }
 
+  /**
+   * Gets a fully qualified name for this constant.
+   */
+  string getAQualifiedName() { none() }
+
   override string toString() { result = this.getName() }
 
   override AstNode getAChild(string pred) {
@@ -295,10 +300,7 @@ class ConstantReadAccess extends ConstantAccess {
 
   final override string getAPrimaryQlClass() { result = "ConstantReadAccess" }
 
-  /**
-   * Gets a fully qualified name for this constant.
-   */
-  string getAQualifiedName() { TResolved(result) = resolveConstantReadAccess(this) }
+  override string getAQualifiedName() { TResolved(result) = resolveConstantReadAccess(this) }
 }
 
 /**
@@ -359,7 +361,7 @@ class ConstantWriteAccess extends ConstantAccess {
    * constants up the namespace chain, the fully qualified name of a nested
    * constant can be ambiguous from just statically looking at the AST.
    */
-  string getAQualifiedName() { result = resolveConstantWriteAccess(this) }
+  override string getAQualifiedName() { result = resolveConstantWriteAccess(this) }
 
   /**
    * Gets a qualified name for this constant. Deprecated in favor of