Fix qhelp test

smowton · web-flow · commit 5101a8e9f32b · 2021-11-24T12:12:56.000Z
diff --git a/java/ql/src/experimental/Security/CWE/CWE-400/ThreadResourceAbuse.java b/java/ql/src/experimental/Security/CWE/CWE-400/ThreadResourceAbuse.java
@@ -1,11 +1,11 @@
 class SleepTest {
 	public void test(int userSuppliedWaitTime) throws Exception {
 		// BAD: no boundary check on wait time
-		Thread.sleep(waitTime);
+		Thread.sleep(userSuppliedWaitTime);
 
 		// GOOD: enforce an upper limit on wait time
-		if (waitTime > 0 && waitTime < 5000) {
-			Thread.sleep(waitTime);
+		if (userSuppliedWaitTime > 0 && userSuppliedWaitTime < 5000) {
+			Thread.sleep(userSuppliedWaitTime);
 		}
 	}
 }

Original file line number	Diff line number	Diff line change
`@@ -1,11 +1,11 @@`
`1`	`1`	`class SleepTest {`
`2`	`2`	`public void test(int userSuppliedWaitTime) throws Exception {`
`3`	`3`	`// BAD: no boundary check on wait time`
`4`		`- Thread.sleep(waitTime);`
	`4`	`+ Thread.sleep(userSuppliedWaitTime);`
`5`	`5`
`6`	`6`	`// GOOD: enforce an upper limit on wait time`
`7`		`- if (waitTime > 0 && waitTime < 5000) {`
`8`		`- Thread.sleep(waitTime);`
	`7`	`+ if (userSuppliedWaitTime > 0 && userSuppliedWaitTime < 5000) {`
	`8`	`+ Thread.sleep(userSuppliedWaitTime);`
`9`	`9`	`}`
`10`	`10`	`}`
`11`	`11`	`}`