Merge pull request #11290 from tamasvajk/kotlin-autoboxing

Kotlin: Exclude .kt files from autoboxing query

Author: tamasvajk

java/ql/src/Violations of Best Practice/legacy/AutoBoxing.ql

@@ -72,12 +72,16 @@ predicate rebox(Assignment e, Variable v) {
 
 from Expr e, string conv
 where
-  boxed(e) and conv = "This expression is implicitly boxed."
-  or
-  unboxed(e) and conv = "This expression is implicitly unboxed."
-  or
-  exists(Variable v | rebox(e, v) |
-    conv =
-      "This expression implicitly unboxes, updates, and reboxes the value of '" + v.getName() + "'."
+  e.getFile().isJavaSourceFile() and
+  (
+    boxed(e) and conv = "This expression is implicitly boxed."
+    or
+    unboxed(e) and conv = "This expression is implicitly unboxed."
+    or
+    exists(Variable v | rebox(e, v) |
+      conv =
+        "This expression implicitly unboxes, updates, and reboxes the value of '" + v.getName() +
+          "'."
+    )
   )
 select e, conv

java/ql/test/kotlin/query-tests/AutoBoxing/AutoBoxing.expected

@@ -0,0 +1 @@
+Violations of Best Practice/legacy/AutoBoxing.ql

java/ql/test/kotlin/query-tests/AutoBoxing/AutoBoxing.qlref

@@ -0,0 +1,5 @@
+fun foo(x: Int?) {
+    if (x != null) {
+        println(x)
+    }
+}