Java: Use shared SuccessorType.

Author: aschackmull

java/ql/lib/semmle/code/java/controlflow/BasicBlocks.qll

@@ -9,7 +9,7 @@ import Dominance
 private import codeql.controlflow.BasicBlock as BB
 
 private module Input implements BB::InputSig<Location> {
-  import SuccessorType
+  import codeql.controlflow.SuccessorType
 
   /** Hold if `t` represents a conditional successor type. */
   predicate successorTypeIsCondition(SuccessorType t) { none() }
@@ -34,7 +34,7 @@ private module Input implements BB::InputSig<Location> {
     result = getASpecificSuccessor(node, t)
     or
     node.getASuccessor() = result and
-    t instanceof NormalSuccessor and
+    t instanceof DirectSuccessor and
     not result = getASpecificSuccessor(node, _)
   }
 

java/ql/lib/semmle/code/java/controlflow/Guards.qll

@@ -140,7 +140,7 @@ private predicate isNonFallThroughPredecessor(SwitchCase sc, ControlFlowNode pre
 }
 
 private module SuccessorTypes implements SharedGuards::SuccessorTypesSig<SuccessorType> {
-  import SuccessorType
+  import codeql.controlflow.SuccessorType
 }
 
 private module GuardsInput implements SharedGuards::InputSig<Location, ControlFlowNode, BasicBlock> {