C++: Address review comments

Author: jketema

cpp/ql/lib/semmle/code/cpp/ir/implementation/raw/internal/TranslatedExpr.qll

@@ -4147,7 +4147,7 @@ private predicate exprImmediatelyDiscarded(Expr expr) {
   exists(ExprStmt s |
     s = expr.getParent() and
     not exists(StmtExpr se | s = se.getStmt().(BlockStmt).getLastStmt()) and
-    not exists(Conversion c | c = expr.getConversion*() and not isTransparentConversion(c))
+    not exists(expr.getConversion())
   )
   or
   exists(CommaExpr c | c.getLeftOperand() = expr)

cpp/ql/test/library-tests/dataflow/asExpr/test.cpp

@@ -42,8 +42,8 @@ void test_aggregate_literal() {
 void test_postfix_crement(int *p, int q) {
   p++; // $ asExpr="... ++" asIndirectExpr="... ++" asExpr=p asIndirectExpr=p
   q++; // $ asExpr="... ++" asExpr=q
-  (p++); // $ numberOfNodes="... ++: 2" numberOfIndirectNodes="... ++: 2" asExpr="... ++" asIndirectExpr="... ++"
-  (q++); // $ numberOfNodes="... ++: 2" asExpr="... ++"
+  (p++); // $ asExpr="... ++" asIndirectExpr="... ++" asExpr="p(... ++)" asIndirectExpr="p(*... ++)"
+  (q++); // $ asExpr="... ++" asExpr="q(... ++)"
   (void)(p++); // $ asExpr="p(... ++)" asIndirectExpr="p(*... ++)"
   (void)(q++); // $ asExpr="q(... ++)"
   (void)p++; // $ asExpr="p(... ++)" asIndirectExpr="p(*... ++)"

cpp/ql/test/library-tests/ir/ir/aliased_ir.expected

@@ -20184,11 +20184,13 @@ ir.cpp:
 # 2731|     r2731_3(int)          = Constant[1]              : 
 # 2731|     r2731_4(int *)        = PointerAdd[4]            : r2731_2, r2731_3
 # 2731|     m2731_5(int *)        = Store[p]                 : &:r2731_1, r2731_4
+# 2731|     r2731_6(int *)        = CopyValue                : r2731_2
 # 2732|     r2732_1(glval<int>)   = VariableAddress[q]       : 
 # 2732|     r2732_2(int)          = Load[q]                  : &:r2732_1, m2730_5
 # 2732|     r2732_3(int)          = Constant[1]              : 
 # 2732|     r2732_4(int)          = Add                      : r2732_2, r2732_3
 # 2732|     m2732_5(int)          = Store[q]                 : &:r2732_1, r2732_4
+# 2732|     r2732_6(int)          = CopyValue                : r2732_2
 # 2733|     r2733_1(glval<int *>) = VariableAddress[p]       : 
 # 2733|     r2733_2(int *)        = Load[p]                  : &:r2733_1, m2731_5
 # 2733|     r2733_3(int)          = Constant[1]              : 

cpp/ql/test/library-tests/ir/ir/raw_ir.expected

@@ -18343,11 +18343,13 @@ ir.cpp:
 # 2731|     r2731_3(int)          = Constant[1]              : 
 # 2731|     r2731_4(int *)        = PointerAdd[4]            : r2731_2, r2731_3
 # 2731|     mu2731_5(int *)       = Store[p]                 : &:r2731_1, r2731_4
+# 2731|     r2731_6(int *)        = CopyValue                : r2731_2
 # 2732|     r2732_1(glval<int>)   = VariableAddress[q]       : 
 # 2732|     r2732_2(int)          = Load[q]                  : &:r2732_1, ~m?
 # 2732|     r2732_3(int)          = Constant[1]              : 
 # 2732|     r2732_4(int)          = Add                      : r2732_2, r2732_3
 # 2732|     mu2732_5(int)         = Store[q]                 : &:r2732_1, r2732_4
+# 2732|     r2732_6(int)          = CopyValue                : r2732_2
 # 2733|     r2733_1(glval<int *>) = VariableAddress[p]       : 
 # 2733|     r2733_2(int *)        = Load[p]                  : &:r2733_1, ~m?
 # 2733|     r2733_3(int)          = Constant[1]              :