C++: Drive-by improvement: Use 'partialFlowFunc' since it is in scope anyway.

MathiasVP · MathiasVP · commit 4551875e2e37 · 2025-08-18T18:10:35.000+02:00
diff --git a/cpp/ql/lib/semmle/code/cpp/ir/dataflow/internal/SsaImpl.qll b/cpp/ql/lib/semmle/code/cpp/ir/dataflow/internal/SsaImpl.qll
@@ -756,9 +756,9 @@ private predicate modeledFlowBarrier(Node n) {
     partialFlowFunc = call.getStaticCallTarget() and
     not partialFlowFunc.isPartialWrite(output)
   |
-    call.getStaticCallTarget().(DataFlow::DataFlowFunction).hasDataFlow(_, output)
+    partialFlowFunc.(DataFlow::DataFlowFunction).hasDataFlow(_, output)
     or
-    call.getStaticCallTarget().(Taint::TaintFunction).hasTaintFlow(_, output)
+    partialFlowFunc.(Taint::TaintFunction).hasTaintFlow(_, output)
   )
   or
   exists(Operand operand, Instruction instr, Node n0, int indirectionIndex |

Original file line number	Diff line number	Diff line change
`@@ -756,9 +756,9 @@ private predicate modeledFlowBarrier(Node n) {`
`756`	`756`	`partialFlowFunc = call.getStaticCallTarget() and`
`757`	`757`	`not partialFlowFunc.isPartialWrite(output)`
`758`	`758`	`\|`
`759`		`- call.getStaticCallTarget().(DataFlow::DataFlowFunction).hasDataFlow(_, output)`
	`759`	`+ partialFlowFunc.(DataFlow::DataFlowFunction).hasDataFlow(_, output)`
`760`	`760`	`or`
`761`		`- call.getStaticCallTarget().(Taint::TaintFunction).hasTaintFlow(_, output)`
	`761`	`+ partialFlowFunc.(Taint::TaintFunction).hasTaintFlow(_, output)`
`762`	`762`	`)`
`763`	`763`	`or`
`764`	`764`	`exists(Operand operand, Instruction instr, Node n0, int indirectionIndex \|`