Shared: Make sure getMadRepresentation is unique

hvitved · hvitved · commit 41f713862782 · 2025-06-16T14:28:05.000+02:00
diff --git a/shared/dataflow/codeql/dataflow/internal/FlowSummaryImpl.qll b/shared/dataflow/codeql/dataflow/internal/FlowSummaryImpl.qll
@@ -686,6 +686,11 @@ module Make<
         derivedFluentFlowPush(_, _, _, head, tail, _)
       }
 
+    pragma[nomagic]
+    private string getUniqueMadRepresentation(SummaryComponent c) {
+      result = strictconcat(string s | s = c.getMadRepresentation() | s, "/")
+    }
+
     /**
      * A (non-empty) stack of summary components.
      *
@@ -732,7 +737,7 @@ module Make<
         exists(SummaryComponent head, SummaryComponentStack tail |
           head = this.head() and
           tail = this.tail() and
-          result = tail.getMadRepresentation() + "." + head.getMadRepresentation()
+          result = tail.getMadRepresentation() + "." + getUniqueMadRepresentation(head)
         )
         or
         exists(SummaryComponent c |

Original file line number	Diff line number	Diff line change
`@@ -686,6 +686,11 @@ module Make<`
`686`	`686`	`derivedFluentFlowPush(_, _, _, head, tail, _)`
`687`	`687`	`}`
`688`	`688`
	`689`	`+ pragma[nomagic]`
	`690`	`+ private string getUniqueMadRepresentation(SummaryComponent c) {`
	`691`	`+ result = strictconcat(string s \| s = c.getMadRepresentation() \| s, "/")`
	`692`	`+ }`
	`693`	`+`
`689`	`694`	`/**`
`690`	`695`	`* A (non-empty) stack of summary components.`
`691`	`696`	`*`
`@@ -732,7 +737,7 @@ module Make<`
`732`	`737`	`exists(SummaryComponent head, SummaryComponentStack tail \|`
`733`	`738`	`head = this.head() and`
`734`	`739`	`tail = this.tail() and`
`735`		`- result = tail.getMadRepresentation() + "." + head.getMadRepresentation()`
	`740`	`+ result = tail.getMadRepresentation() + "." + getUniqueMadRepresentation(head)`
`736`	`741`	`)`
`737`	`742`	`or`
`738`	`743`	`exists(SummaryComponent c \|`