Swift: delete TargetFile's move assignment

Author: redsun82

swift/extractor/infra/TargetFile.cpp

@@ -67,16 +67,6 @@ std::optional<TargetFile> TargetFile::create(std::string_view target,
   return std::nullopt;
 }
 
-TargetFile& TargetFile::operator=(TargetFile&& other) {
-  if (this != &other) {
-    commit();
-    workingPath = std::move(other.workingPath);
-    targetPath = std::move(other.targetPath);
-    out = std::move(other.out);
-  }
-  return *this;
-}
-
 void TargetFile::commit() {
   if (out.is_open()) {
     out.close();

swift/extractor/infra/TargetFile.h

@@ -24,7 +24,8 @@ class TargetFile {
   ~TargetFile() { commit(); }
 
   TargetFile(TargetFile&& other) = default;
-  TargetFile& operator=(TargetFile&& other);
+  // move assignment deleted as non-trivial and not needed
+  TargetFile& operator=(TargetFile&& other) = delete;
 
   template <typename T>
   TargetFile& operator<<(T&& value) {