Merge pull request #7628 from michaelnebel/csharp/issue-7609

C#: Fix false positive alert for shadowing on record types.

Author: michaelnebel

csharp/ql/lib/change-notes/2022-01-18-local-shadows-member.md

@@ -0,0 +1,4 @@
+---
+category: minorAnalysis
+---
+* The query `cs/local-shadows-member` no longer highlights parameters of `record` types.

csharp/ql/src/Bad Practices/Declarations/LocalScopeVariableShadowsMember.ql

@@ -39,6 +39,10 @@ private predicate acceptableShadowing(LocalScopeVariable v, Member m) {
     )
     or
     t.getAConstructor().getAParameter() = v
+    or
+    // Record types have auto-generated Deconstruct methods, which declare an out parameter
+    // with the same name as the property field(s).
+    t.(RecordType).getAMethod("Deconstruct").getAParameter() = v
   )
 }
 

csharp/ql/test/query-tests/Bad Practices/Declarations/LocalScopeVariableShadowsMember/LocalScopeVariableShadowsMember.cs

@@ -61,4 +61,8 @@ class C4 : C
     {
         public C4(int f) { } // GOOD
     }
+
+    record class GoodRecordClass(object Prop1, object Prop2) { } // GOOD
+
+    record struct GoodRecordStruct(object Prop1, object Prop2) { } // GOOD
 }