Address review comment

hvitved · hvitved · commit 3c91333d0b79 · 2024-05-03T14:09:41.000+02:00
diff --git a/csharp/ql/lib/semmle/code/csharp/ExprOrStmtParent.qll b/csharp/ql/lib/semmle/code/csharp/ExprOrStmtParent.qll
@@ -66,7 +66,7 @@ private ControlFlowElement getBody(Callable c) {
 }
 
 pragma[nomagic]
-private Location getASourceLocation(Element e) {
+private SourceLocation getASourceLocation(Element e) {
   result = e.getALocation().(SourceLocation) and
   not exists(e.getALocation().(SourceLocation).getMappedLocation())
   or
diff --git a/csharp/ql/lib/semmle/code/csharp/Location.qll b/csharp/ql/lib/semmle/code/csharp/Location.qll
@@ -63,7 +63,7 @@ class EmptyLocation extends Location {
  */
 class SourceLocation extends Location, @location_default {
   /** Gets the location that takes into account `#line` directives, if any. */
-  Location getMappedLocation() {
+  SourceLocation getMappedLocation() {
     locations_mapped(this, result) and
     not exists(LineDirective l | l.getALocation() = this)
   }

Original file line number	Diff line number	Diff line change
`@@ -66,7 +66,7 @@ private ControlFlowElement getBody(Callable c) {`
`66`	`66`	`}`
`67`	`67`
`68`	`68`	`pragma[nomagic]`
`69`		`-private Location getASourceLocation(Element e) {`
	`69`	`+private SourceLocation getASourceLocation(Element e) {`
`70`	`70`	`result = e.getALocation().(SourceLocation) and`
`71`	`71`	`not exists(e.getALocation().(SourceLocation).getMappedLocation())`
`72`	`72`	`or`
Original file line number	Diff line number	Diff line change
`@@ -63,7 +63,7 @@ class EmptyLocation extends Location {`
`63`	`63`	`*/`
`64`	`64`	`class SourceLocation extends Location, @location_default {`
`65`	`65`	/** Gets the location that takes into account `#line` directives, if any. */
`66`		`- Location getMappedLocation() {`
	`66`	`+ SourceLocation getMappedLocation() {`
`67`	`67`	`locations_mapped(this, result) and`
`68`	`68`	`not exists(LineDirective l \| l.getALocation() = this)`
`69`	`69`	`}`