Merge pull request #11907 from michaelnebel/csharp/cil/attributes

C#: CIL attributes

Author: michaelnebel

csharp/extractor/Semmle.Extraction.CIL/Entities/DefinitionMethod.cs

@@ -92,7 +92,8 @@ public override IEnumerable<IExtractionProduct> Contents
                         yield return Tuples.cil_parameter_out(pe);
                     if (p.Attributes.HasFlag(ParameterAttributes.In))
                         yield return Tuples.cil_parameter_in(pe);
-                    Attribute.Populate(Context, pe, p.GetCustomAttributes());
+                    foreach (var c in Attribute.Populate(Context, pe, p.GetCustomAttributes()))
+                        yield return c;
                 }
 
                 yield return Tuples.metadata_handle(this, Context.Assembly, MetadataTokens.GetToken(handle));
@@ -205,7 +206,8 @@ public override IEnumerable<IExtractionProduct> Contents
                     yield return Tuples.cil_newslot(this);
 
                 // Populate attributes
-                Attribute.Populate(Context, this, md.GetCustomAttributes());
+                foreach (var c in Attribute.Populate(Context, this, md.GetCustomAttributes()))
+                    yield return c;
             }
         }
 

csharp/ql/lib/change-notes/2023-01-18-cilmethodattributes.md

@@ -0,0 +1,4 @@
+---
+category: minorAnalysis
+---
+* Attributes on methods in CIL are now extracted (Bugfix).