Skip to content

Commit 3a0a899

Browse files
committed
java: fix ql alerts
1 parent 61a3e96 commit 3a0a899

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

java/ql/lib/semmle/code/java/ConflictingAccess.qll

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -185,7 +185,7 @@ class ClassAnnotatedAsThreadSafe extends Class {
185185
Monitors::locallyMonitors(e, monitor)
186186
or
187187
// recursive case
188-
exists(MethodCall c, Expr e0, Method m0 | this.has_onelocked_access(f, e0, m0, write, monitor) |
188+
exists(MethodCall c, Method m0 | this.has_onelocked_access(f, _, m0, write, monitor) |
189189
m = c.getEnclosingCallable() and
190190
not m0.isPublic() and
191191
c.getCallee().getSourceDeclaration() = m0 and
@@ -223,8 +223,8 @@ class ClassAnnotatedAsThreadSafe extends Class {
223223
not this.has_unlocked_public_access(f, _, _, _)
224224
or
225225
// recursive case
226-
exists(MethodCall c, Expr e0, Method m0, Monitors::Monitor monitor0 |
227-
this.has_onepluslocked_access(f, e0, m0, write, monitor0) and
226+
exists(MethodCall c, Method m0, Monitors::Monitor monitor0 |
227+
this.has_onepluslocked_access(f, _, m0, write, monitor0) and
228228
m = c.getEnclosingCallable() and
229229
not m0.isPublic() and
230230
c.getCallee().getSourceDeclaration() = m0 and
@@ -258,7 +258,7 @@ class ClassAnnotatedAsThreadSafe extends Class {
258258
not Monitors::locallyMonitors(e, monitor)
259259
or
260260
// recursive case
261-
exists(MethodCall c, Expr e0, Method m0 | this.escapes_monitor(f, e0, m0, write, monitor) |
261+
exists(MethodCall c, Method m0 | this.escapes_monitor(f, _, m0, write, monitor) |
262262
m = c.getEnclosingCallable() and
263263
not m0.isPublic() and
264264
c.getCallee().getSourceDeclaration() = m0 and

0 commit comments

Comments
 (0)