Merge pull request #11045 from tamasvajk/kotlin-confusing-default

Kotlin: Excluded compiler generated methods from `java/confusing-method-signature`

Author: tamasvajk

java/ql/src/Violations of Best Practice/Naming Conventions/ConfusingOverloading.ql

@@ -57,6 +57,8 @@ private predicate candidateMethod(RefType t, Method m, string name, int numParam
   m.getNumberOfParameters() = numParam and
   m = m.getSourceDeclaration() and
   not m.getAnAnnotation() instanceof DeprecatedAnnotation and
+  // Exclude compiler generated methods, such as Kotlin `$default` methods:
+  not m.isCompilerGenerated() and
   not whitelist(name)
 }
 

java/ql/test/kotlin/query-tests/ConfusingMethodSignature/Test.kt

@@ -7,3 +7,8 @@ class C {
         prop(this)
     }
 }
+
+class A {
+    fun <T : Any> fn(value: T, i: Int = 1) {}
+    fun fn(value: String, i: Int = 1) {}
+}