C++: Fix phi-phi flow.

MathiasVP · MathiasVP · commit 36b7b6cffe62 · 2023-09-14T14:02:03.000+01:00
diff --git a/cpp/ql/lib/semmle/code/cpp/ir/dataflow/internal/SsaInternals.qll b/cpp/ql/lib/semmle/code/cpp/ir/dataflow/internal/SsaInternals.qll
@@ -766,7 +766,7 @@ predicate fromPhiNode(SsaPhiNode nodeFrom, Node nodeTo) {
     or
     exists(PhiNode phiTo |
       phi != phiTo and
-      lastRefRedefExt(phi, _, _, phiTo) and
+      lastRefRedefExt(phi, bb1, i1, phiTo) and
       nodeTo.(SsaPhiNode).getPhiNode() = phiTo
     )
   )

Original file line number	Diff line number	Diff line change
`@@ -766,7 +766,7 @@ predicate fromPhiNode(SsaPhiNode nodeFrom, Node nodeTo) {`
`766`	`766`	`or`
`767`	`767`	`exists(PhiNode phiTo \|`
`768`	`768`	`phi != phiTo and`
`769`		`- lastRefRedefExt(phi, _, _, phiTo) and`
	`769`	`+ lastRefRedefExt(phi, bb1, i1, phiTo) and`
`770`	`770`	`nodeTo.(SsaPhiNode).getPhiNode() = phiTo`
`771`	`771`	`)`
`772`	`772`	`)`