Use more specific hasGlobalName() for stdlib function free(3)

mario-campos · mario-campos · commit 3195f0c8288f · 2024-04-26T09:10:40.000-05:00
Based on the CodeQL documentation's example of strncpy(3) and strlen(3): https://codeql.github.com/docs/codeql-language-guides/hash-consing-and-value-numbering/#example-query
diff --git a/cpp/ql/src/experimental/Best Practices/GuardedFree.ql b/cpp/ql/src/experimental/Best Practices/GuardedFree.ql
@@ -14,7 +14,7 @@
 import cpp
 
 class FreeCall extends FunctionCall {
-  FreeCall() { this.getTarget().hasName("free") }
+  FreeCall() { this.getTarget().hasGlobalName("free") }
 }
 
 from IfStmt stmt, FreeCall fc, Variable v

Original file line number	Diff line number	Diff line change
`@@ -14,7 +14,7 @@`
`14`	`14`	`import cpp`
`15`	`15`
`16`	`16`	`class FreeCall extends FunctionCall {`
`17`		`- FreeCall() { this.getTarget().hasName("free") }`
	`17`	`+ FreeCall() { this.getTarget().hasGlobalName("free") }`
`18`	`18`	`}`
`19`	`19`
`20`	`20`	`from IfStmt stmt, FreeCall fc, Variable v`