Merge pull request #7552 from smowton/smowton/fix/local-parameterized-classes

Note that parameterizations of local classes are themselves local

Author: aschackmull

java/ql/lib/semmle/code/java/Type.qll

@@ -905,7 +905,7 @@ class Interface extends ClassOrInterface, @interface {
 /** A class or interface. */
 class ClassOrInterface extends RefType, @classorinterface {
   /** Holds if this class or interface is local. */
-  predicate isLocal() { isLocalClassOrInterface(this, _) }
+  predicate isLocal() { isLocalClassOrInterface(this.getSourceDeclaration(), _) }
 
   /** Holds if this class or interface is package protected, that is, neither public nor private nor protected. */
   predicate isPackageProtected() {

java/ql/test/library-tests/localclasses/Test.java

@@ -0,0 +1,11 @@
+public class Test {
+
+  public static void method() {
+
+    class GenericLocal<T> { }
+
+    GenericLocal<Integer> instantiated = new GenericLocal<>();
+
+  }
+
+}

java/ql/test/library-tests/localclasses/test.expected

@@ -0,0 +1,2 @@
+| Test$1GenericLocal.class:0:0:0:0 | GenericLocal<Integer> |
+| Test.java:5:11:5:22 | GenericLocal |

java/ql/test/library-tests/localclasses/test.ql

@@ -0,0 +1,7 @@
+import java
+
+from ClassOrInterface ci
+where
+  ci.getSourceDeclaration().fromSource() and
+  ci.isLocal()
+select ci