Merge pull request #10023 from aschackmull/java/numbertype-perf

aschackmull · web-flow · commit 28e4224ab1c5 · 2022-08-16T09:52:55.000+02:00
Java: Minor perf improvement.
diff --git a/java/ql/lib/semmle/code/java/JDK.qll b/java/ql/lib/semmle/code/java/JDK.qll
@@ -141,7 +141,8 @@ class TypeNumber extends RefType {
 
 /** A (reflexive, transitive) subtype of `java.lang.Number`. */
 class NumberType extends RefType {
-  NumberType() { exists(TypeNumber number | hasDescendant(number, this)) }
+  pragma[nomagic]
+  NumberType() { this.getASupertype*() instanceof TypeNumber }
 }
 
 /** An immutable type. */

Original file line number	Diff line number	Diff line change
`@@ -141,7 +141,8 @@ class TypeNumber extends RefType {`
`141`	`141`
`142`	`142`	/** A (reflexive, transitive) subtype of `java.lang.Number`. */
`143`	`143`	`class NumberType extends RefType {`
`144`		`- NumberType() { exists(TypeNumber number \| hasDescendant(number, this)) }`
	`144`	`+ pragma[nomagic]`
	`145`	`+ NumberType() { this.getASupertype*() instanceof TypeNumber }`
`145`	`146`	`}`
`146`	`147`
`147`	`148`	`/** An immutable type. */`