Swift: replace empty IpaInfo() with a clearer True value

Author: redsun82

swift/codegen/lib/schema/schema.py

@@ -86,7 +86,8 @@ class Class:
     properties: List[Property] = field(default_factory=list)
     group: str = ""
     pragmas: List[str] = field(default_factory=list)
-    ipa: Optional[IpaInfo] = None
+    ipa: Optional[Union[IpaInfo, bool]] = None
+    """^^^ filled with `True` for non-final classes with only synthesized final descendants """
     doc: List[str] = field(default_factory=list)
     default_doc_name: Optional[str] = None
 
@@ -248,6 +249,10 @@ def _toposort_classes_by_group(classes: typing.Dict[str, Class]) -> typing.Dict[
 
 
 def _fill_ipa_information(classes: typing.Dict[str, Class]):
+    """ Take a dictionary where the `ipa` field is filled for all explicitly synthesized classes
+    and updated it so that all non-final classes that have only synthesized final descendants
+    get `True` as` value for the `ipa` field
+    """
     if not classes:
         return
 
@@ -270,7 +275,7 @@ def fill_is_ipa(name: str):
 
     for name, cls in classes.items():
         if cls.ipa is None and is_ipa[name]:
-            cls.ipa = IpaInfo()
+            cls.ipa = True
 
 
 def load(m: types.ModuleType) -> Schema:

swift/codegen/test/test_schema.py

@@ -340,7 +340,7 @@ class B(A):
             pass
 
     assert data.classes == {
-        'A': schema.Class('A', derived={'B'}, ipa=schema.IpaInfo()),
+        'A': schema.Class('A', derived={'B'}, ipa=True),
         'B': schema.Class('B', bases=['A'], ipa=schema.IpaInfo(from_class="A")),
     }
 
@@ -381,7 +381,7 @@ class B(A):
             pass
 
     assert data.classes == {
-        'A': schema.Class('A', derived={'B'}, ipa=schema.IpaInfo()),
+        'A': schema.Class('A', derived={'B'}, ipa=True),
         'B': schema.Class('B', bases=['A'], ipa=schema.IpaInfo(on_arguments={'a': 'A', 'i': 'int'})),
     }
 
@@ -439,8 +439,8 @@ class C(Root):
 
     assert data.classes == {
         'Root': schema.Class('Root', derived={'Base', 'C'}),
-        'Base': schema.Class('Base', bases=['Root'], derived={'Intermediate', 'B'}, ipa=schema.IpaInfo()),
-        'Intermediate': schema.Class('Intermediate', bases=['Base'], derived={'A'}, ipa=schema.IpaInfo()),
+        'Base': schema.Class('Base', bases=['Root'], derived={'Intermediate', 'B'}, ipa=True),
+        'Intermediate': schema.Class('Intermediate', bases=['Base'], derived={'A'}, ipa=True),
         'A': schema.Class('A', bases=['Intermediate'], ipa=schema.IpaInfo(on_arguments={'a': 'Base', 'i': 'int'})),
         'B': schema.Class('B', bases=['Base'], ipa=schema.IpaInfo(from_class='Base')),
         'C': schema.Class('C', bases=['Root']),