apply review suggestions

Jami Cogswell · atorralba · commit 25cb3236a238 · 2022-10-04T12:33:24.000+02:00
diff --git a/java/ql/lib/change-notes/2022-09-22-android-deeplink-flow-steps.md b/java/ql/lib/change-notes/2022-09-22-android-deeplink-flow-steps.md
@@ -2,4 +2,4 @@
 category: minorAnalysis
 ---
 * Added data flow steps for tainted Android intents that are sent to services and receivers.
-* Updated data flow step for tainted Android intents that are sent to activities.
+* Improved the data flow step for tainted Android intents that are sent to activities so that more cases are covered.
diff --git a/java/ql/lib/change-notes/2022-09-22-android-deprecate-contextstartactivitymethod.md b/java/ql/lib/change-notes/2022-09-22-android-deprecate-contextstartactivitymethod.md
@@ -0,0 +1,4 @@
+---
+category: deprecated
+---
+* Deprecated `ContextStartActivityMethod`. Use `StartActivityMethod` instead.
diff --git a/java/ql/lib/semmle/code/java/frameworks/android/Intent.qll b/java/ql/lib/semmle/code/java/frameworks/android/Intent.qll
@@ -221,7 +221,7 @@ class GrantWriteUriPermissionFlag extends GrantUriPermissionFlag {
   GrantWriteUriPermissionFlag() { this.hasName("FLAG_GRANT_WRITE_URI_PERMISSION") }
 }
 
-/** The instantiation of an `android.content.Intent` instance. */
+/** An instantiation of `android.content.Intent`. */
 private class NewIntent extends ClassInstanceExpr {
   NewIntent() { this.getConstructedType() instanceof TypeIntent }
 
@@ -232,7 +232,7 @@ private class NewIntent extends ClassInstanceExpr {
   }
 }
 
-/** A call to a method that starts an Android component */
+/** A call to a method that starts an Android component. */
 private class StartComponentMethodAccess extends MethodAccess {
   StartComponentMethodAccess() {
     this.getMethod().overrides*(any(StartActivityMethod m)) or

-Original file line number
+Diff line change
@@ @@ -0,0 +1,4 @@ @@
 +---
 +category: deprecated
 +---
 +* Deprecated `ContextStartActivityMethod`. Use `StartActivityMethod` instead.
Original file line number	Diff line number	Diff line change
`@@ -221,7 +221,7 @@ class GrantWriteUriPermissionFlag extends GrantUriPermissionFlag {`
`221`	`221`	`GrantWriteUriPermissionFlag() { this.hasName("FLAG_GRANT_WRITE_URI_PERMISSION") }`
`222`	`222`	`}`
`223`	`223`
`224`		-/** The instantiation of an `android.content.Intent` instance. */
	`224`	+/** An instantiation of `android.content.Intent`. */
`225`	`225`	`private class NewIntent extends ClassInstanceExpr {`
`226`	`226`	`NewIntent() { this.getConstructedType() instanceof TypeIntent }`
`227`	`227`
`@@ -232,7 +232,7 @@ private class NewIntent extends ClassInstanceExpr {`
`232`	`232`	`}`
`233`	`233`	`}`
`234`	`234`
`235`		`-/** A call to a method that starts an Android component */`
	`235`	`+/** A call to a method that starts an Android component. */`
`236`	`236`	`private class StartComponentMethodAccess extends MethodAccess {`
`237`	`237`	`StartComponentMethodAccess() {`
`238`	`238`	`this.getMethod().overrides*(any(StartActivityMethod m)) or`