Merge pull request #19476 from yoff/ruby/DeadStoreOfLocal-precision-high

yoff · web-flow · commit 1c863b1bd438 · 2025-05-13T13:56:22.000+02:00
ruby: adjust precision of `rb/useless-assignment-to-local`
diff --git a/ruby/ql/integration-tests/query-suite/ruby-code-quality.qls.expected b/ruby/ql/integration-tests/query-suite/ruby-code-quality.qls.expected
@@ -1,2 +1,3 @@
 ql/ruby/ql/src/queries/performance/DatabaseQueryInLoop.ql
+ql/ruby/ql/src/queries/variables/DeadStoreOfLocal.ql
 ql/ruby/ql/src/queries/variables/UninitializedLocal.ql
diff --git a/ruby/ql/src/change-notes/2025-05-12-rb-useless-assignment-to-local-precision-high.md b/ruby/ql/src/change-notes/2025-05-12-rb-useless-assignment-to-local-precision-high.md
@@ -0,0 +1,5 @@
+---
+category: queryMetadata
+---
+
+* The precision of `rb/useless-assignment-to-local` has been adjusted from `medium` to `high`.
diff --git a/ruby/ql/src/queries/variables/DeadStoreOfLocal.ql b/ruby/ql/src/queries/variables/DeadStoreOfLocal.ql
@@ -8,7 +8,7 @@
  * @tags maintainability
  *       quality
  *       external/cwe/cwe-563
- * @precision medium
+ * @precision high
  */
 
 import codeql.ruby.AST

Original file line number	Diff line number	Diff line change
`@@ -1,2 +1,3 @@`
`1`	`1`	`ql/ruby/ql/src/queries/performance/DatabaseQueryInLoop.ql`
	`2`	`+ql/ruby/ql/src/queries/variables/DeadStoreOfLocal.ql`
`2`	`3`	`ql/ruby/ql/src/queries/variables/UninitializedLocal.ql`
-Original file line number
+Diff line change
@@ @@ -0,0 +1,5 @@ @@
 +---
 +category: queryMetadata
 +---
++
 +* The precision of `rb/useless-assignment-to-local` has been adjusted from `medium` to `high`.