Skip to content

Commit 1a65a27

Browse files
owen-mcowen-mc
committed
Update test expectations
In #8641, `localFlowExit` was changed to use `Stage2::readStepCand` instead of `read`, which means that the big-step relation is broken up less. This causes test result changes. Nothing is lost from the `select` clause, but some results may have fewer paths, and fewer nodes and edges are output in the test results.
1 parent 71aeeee commit 1a65a27

File tree

15 files changed

+0
-345
lines changed

15 files changed

+0
-345
lines changed

‎go/ql/test/experimental/CWE-918/SSRF.expected‎

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -13,11 +13,6 @@ edges
1313
| new-tests.go:62:31:62:38 | selection of Body : ReadCloser | new-tests.go:69:11:69:57 | call to Sprintf |
1414
| new-tests.go:62:31:62:38 | selection of Body : ReadCloser | new-tests.go:74:12:74:58 | call to Sprintf |
1515
| new-tests.go:78:18:78:24 | selection of URL : pointer type | new-tests.go:79:11:79:46 | ...+... |
16-
| new-tests.go:81:37:81:43 | implicit dereference : URL | new-tests.go:81:37:81:43 | implicit dereference : URL |
17-
| new-tests.go:81:37:81:43 | implicit dereference : URL | new-tests.go:81:37:81:43 | selection of URL : pointer type |
18-
| new-tests.go:81:37:81:43 | implicit dereference : URL | new-tests.go:82:11:82:46 | ...+... |
19-
| new-tests.go:81:37:81:43 | selection of URL : pointer type | new-tests.go:81:37:81:43 | implicit dereference : URL |
20-
| new-tests.go:81:37:81:43 | selection of URL : pointer type | new-tests.go:81:37:81:43 | selection of URL : pointer type |
2116
| new-tests.go:81:37:81:43 | selection of URL : pointer type | new-tests.go:82:11:82:46 | ...+... |
2217
| new-tests.go:86:10:86:20 | call to Vars : map type | new-tests.go:88:11:88:46 | ...+... |
2318
| new-tests.go:95:18:95:45 | call to URLParam : string | new-tests.go:96:11:96:46 | ...+... |
@@ -46,7 +41,6 @@ nodes
4641
| new-tests.go:74:12:74:58 | call to Sprintf | semmle.label | call to Sprintf |
4742
| new-tests.go:78:18:78:24 | selection of URL : pointer type | semmle.label | selection of URL : pointer type |
4843
| new-tests.go:79:11:79:46 | ...+... | semmle.label | ...+... |
49-
| new-tests.go:81:37:81:43 | implicit dereference : URL | semmle.label | implicit dereference : URL |
5044
| new-tests.go:81:37:81:43 | selection of URL : pointer type | semmle.label | selection of URL : pointer type |
5145
| new-tests.go:82:11:82:46 | ...+... | semmle.label | ...+... |
5246
| new-tests.go:86:10:86:20 | call to Vars : map type | semmle.label | call to Vars : map type |

‎go/ql/test/library-tests/semmle/go/frameworks/Beego/ReflectedXss.expected‎

Lines changed: 0 additions & 125 deletions
Large diffs are not rendered by default.

‎go/ql/test/library-tests/semmle/go/frameworks/BeegoOrm/StoredXss.expected‎

Lines changed: 0 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,6 @@
11
edges
22
| test.go:77:13:77:16 | &... : pointer type | test.go:78:13:78:29 | type conversion |
33
| test.go:77:13:77:16 | &... : pointer type | test.go:79:13:79:43 | type conversion |
4-
| test.go:77:13:77:16 | &... : pointer type | test.go:79:20:79:33 | selection of substructs : slice type |
5-
| test.go:77:13:77:16 | &... : pointer type | test.go:79:20:79:36 | index expression : SubStruct |
6-
| test.go:79:20:79:33 | selection of substructs : slice type | test.go:79:13:79:43 | type conversion |
7-
| test.go:79:20:79:33 | selection of substructs : slice type | test.go:79:20:79:36 | index expression : SubStruct |
8-
| test.go:79:20:79:36 | index expression : SubStruct | test.go:79:13:79:43 | type conversion |
94
| test.go:82:22:82:26 | &... : pointer type | test.go:83:13:83:30 | type conversion |
105
| test.go:86:21:86:25 | &... : pointer type | test.go:87:13:87:30 | type conversion |
116
| test.go:92:20:92:36 | call to Value : string | test.go:92:13:92:37 | type conversion |
@@ -18,14 +13,6 @@ edges
1813
| test.go:99:20:99:40 | call to RawValue : basic interface type | test.go:99:13:99:50 | type conversion |
1914
| test.go:100:20:100:38 | call to String : string | test.go:100:13:100:39 | type conversion |
2015
| test.go:106:9:106:13 | &... : pointer type | test.go:107:13:107:33 | type conversion |
21-
| test.go:106:9:106:13 | &... : pointer type | test.go:107:20:107:26 | implicit dereference : MyStruct |
22-
| test.go:106:9:106:13 | &... : pointer type | test.go:107:20:107:26 | index expression : pointer type |
23-
| test.go:107:20:107:26 | implicit dereference : MyStruct | test.go:107:13:107:33 | type conversion |
24-
| test.go:107:20:107:26 | implicit dereference : MyStruct | test.go:107:20:107:26 | implicit dereference : MyStruct |
25-
| test.go:107:20:107:26 | implicit dereference : MyStruct | test.go:107:20:107:26 | index expression : pointer type |
26-
| test.go:107:20:107:26 | index expression : pointer type | test.go:107:13:107:33 | type conversion |
27-
| test.go:107:20:107:26 | index expression : pointer type | test.go:107:20:107:26 | implicit dereference : MyStruct |
28-
| test.go:107:20:107:26 | index expression : pointer type | test.go:107:20:107:26 | index expression : pointer type |
2916
| test.go:110:9:110:12 | &... : pointer type | test.go:111:13:111:29 | type conversion |
3017
| test.go:114:12:114:19 | &... : pointer type | test.go:115:13:115:48 | type conversion |
3118
| test.go:118:16:118:24 | &... : pointer type | test.go:119:13:119:43 | type conversion |
@@ -43,8 +30,6 @@ nodes
4330
| test.go:77:13:77:16 | &... : pointer type | semmle.label | &... : pointer type |
4431
| test.go:78:13:78:29 | type conversion | semmle.label | type conversion |
4532
| test.go:79:13:79:43 | type conversion | semmle.label | type conversion |
46-
| test.go:79:20:79:33 | selection of substructs : slice type | semmle.label | selection of substructs : slice type |
47-
| test.go:79:20:79:36 | index expression : SubStruct | semmle.label | index expression : SubStruct |
4833
| test.go:82:22:82:26 | &... : pointer type | semmle.label | &... : pointer type |
4934
| test.go:83:13:83:30 | type conversion | semmle.label | type conversion |
5035
| test.go:86:21:86:25 | &... : pointer type | semmle.label | &... : pointer type |
@@ -69,8 +54,6 @@ nodes
6954
| test.go:100:20:100:38 | call to String : string | semmle.label | call to String : string |
7055
| test.go:106:9:106:13 | &... : pointer type | semmle.label | &... : pointer type |
7156
| test.go:107:13:107:33 | type conversion | semmle.label | type conversion |
72-
| test.go:107:20:107:26 | implicit dereference : MyStruct | semmle.label | implicit dereference : MyStruct |
73-
| test.go:107:20:107:26 | index expression : pointer type | semmle.label | index expression : pointer type |
7457
| test.go:110:9:110:12 | &... : pointer type | semmle.label | &... : pointer type |
7558
| test.go:111:13:111:29 | type conversion | semmle.label | type conversion |
7659
| test.go:114:12:114:19 | &... : pointer type | semmle.label | &... : pointer type |

‎go/ql/test/library-tests/semmle/go/frameworks/Chi/ReflectedXss.expected‎

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,11 @@
11
edges
2-
| test.go:13:12:13:16 | implicit dereference : URL | test.go:13:12:13:16 | implicit dereference : URL |
3-
| test.go:13:12:13:16 | implicit dereference : URL | test.go:13:12:13:16 | selection of URL : pointer type |
4-
| test.go:13:12:13:16 | implicit dereference : URL | test.go:13:12:13:21 | selection of Path : string |
5-
| test.go:13:12:13:16 | selection of URL : pointer type | test.go:13:12:13:16 | implicit dereference : URL |
6-
| test.go:13:12:13:16 | selection of URL : pointer type | test.go:13:12:13:16 | selection of URL : pointer type |
72
| test.go:13:12:13:16 | selection of URL : pointer type | test.go:13:12:13:21 | selection of Path : string |
83
| test.go:13:12:13:21 | selection of Path : string | test.go:21:18:21:23 | hidden : string |
94
| test.go:21:18:21:23 | hidden : string | test.go:21:11:21:24 | type conversion |
105
| test.go:22:18:22:45 | call to URLParam : string | test.go:22:11:22:46 | type conversion |
116
| test.go:23:18:23:60 | call to URLParamFromCtx : string | test.go:23:11:23:61 | type conversion |
127
| test.go:24:18:24:71 | call to URLParam : string | test.go:24:11:24:72 | type conversion |
138
nodes
14-
| test.go:13:12:13:16 | implicit dereference : URL | semmle.label | implicit dereference : URL |
159
| test.go:13:12:13:16 | selection of URL : pointer type | semmle.label | selection of URL : pointer type |
1610
| test.go:13:12:13:21 | selection of Path : string | semmle.label | selection of Path : string |
1711
| test.go:21:11:21:24 | type conversion | semmle.label | type conversion |

‎go/ql/test/library-tests/semmle/go/frameworks/Echo/OpenRedirect.expected‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
11
edges
22
| test.go:170:11:170:32 | call to Param : string | test.go:171:20:171:24 | param |
33
| test.go:176:11:176:32 | call to Param : string | test.go:180:20:180:28 | ...+... |
4-
| test.go:188:10:188:26 | selection of URL : pointer type | test.go:188:10:188:26 | selection of URL : pointer type |
5-
| test.go:188:10:188:26 | selection of URL : pointer type | test.go:188:10:188:26 | selection of URL : pointer type |
64
| test.go:188:10:188:26 | selection of URL : pointer type | test.go:191:21:191:32 | call to String |
75
| test.go:188:10:188:26 | selection of URL : pointer type | test.go:191:21:191:32 | call to String |
86
nodes

‎go/ql/test/library-tests/semmle/go/frameworks/Echo/ReflectedXss.expected‎

Lines changed: 0 additions & 40 deletions
Original file line numberDiff line numberDiff line change
@@ -7,41 +7,10 @@ edges
77
| test.go:43:9:43:34 | call to FormValue : string | test.go:44:16:44:18 | val |
88
| test.go:49:2:49:30 | ... := ...[0] : Values | test.go:50:16:50:37 | index expression |
99
| test.go:55:2:55:46 | ... := ...[0] : pointer type | test.go:59:20:59:25 | buffer |
10-
| test.go:64:2:64:31 | ... := ...[0] : pointer type | test.go:65:16:65:19 | implicit dereference : Form |
11-
| test.go:64:2:64:31 | ... := ...[0] : pointer type | test.go:65:16:65:25 | selection of Value : map type |
12-
| test.go:64:2:64:31 | ... := ...[0] : pointer type | test.go:65:16:65:38 | index expression : slice type |
1310
| test.go:64:2:64:31 | ... := ...[0] : pointer type | test.go:65:16:65:41 | index expression |
14-
| test.go:65:16:65:19 | implicit dereference : Form | test.go:65:16:65:19 | implicit dereference : Form |
15-
| test.go:65:16:65:19 | implicit dereference : Form | test.go:65:16:65:25 | selection of Value : map type |
16-
| test.go:65:16:65:19 | implicit dereference : Form | test.go:65:16:65:38 | index expression : slice type |
17-
| test.go:65:16:65:19 | implicit dereference : Form | test.go:65:16:65:41 | index expression |
18-
| test.go:65:16:65:25 | selection of Value : map type | test.go:65:16:65:38 | index expression : slice type |
19-
| test.go:65:16:65:25 | selection of Value : map type | test.go:65:16:65:41 | index expression |
20-
| test.go:65:16:65:38 | index expression : slice type | test.go:65:16:65:41 | index expression |
21-
| test.go:70:2:70:31 | ... := ...[0] : pointer type | test.go:71:16:71:19 | implicit dereference : Form |
22-
| test.go:70:2:70:31 | ... := ...[0] : pointer type | test.go:71:16:71:24 | selection of File : map type |
23-
| test.go:70:2:70:31 | ... := ...[0] : pointer type | test.go:71:16:71:40 | index expression : slice type |
2411
| test.go:70:2:70:31 | ... := ...[0] : pointer type | test.go:75:20:75:25 | buffer |
25-
| test.go:71:16:71:19 | implicit dereference : Form | test.go:71:16:71:19 | implicit dereference : Form |
26-
| test.go:71:16:71:19 | implicit dereference : Form | test.go:71:16:71:24 | selection of File : map type |
27-
| test.go:71:16:71:19 | implicit dereference : Form | test.go:71:16:71:40 | index expression : slice type |
28-
| test.go:71:16:71:19 | implicit dereference : Form | test.go:75:20:75:25 | buffer |
29-
| test.go:71:16:71:24 | selection of File : map type | test.go:71:16:71:40 | index expression : slice type |
30-
| test.go:71:16:71:24 | selection of File : map type | test.go:75:20:75:25 | buffer |
31-
| test.go:71:16:71:40 | index expression : slice type | test.go:75:20:75:25 | buffer |
32-
| test.go:80:2:80:32 | ... := ...[0] : pointer type | test.go:81:16:81:18 | implicit dereference : Cookie |
3312
| test.go:80:2:80:32 | ... := ...[0] : pointer type | test.go:81:16:81:24 | selection of Value |
34-
| test.go:81:16:81:18 | implicit dereference : Cookie | test.go:81:16:81:18 | implicit dereference : Cookie |
35-
| test.go:81:16:81:18 | implicit dereference : Cookie | test.go:81:16:81:24 | selection of Value |
36-
| test.go:86:13:86:25 | call to Cookies : slice type | test.go:87:16:87:25 | implicit dereference : Cookie |
37-
| test.go:86:13:86:25 | call to Cookies : slice type | test.go:87:16:87:25 | index expression : pointer type |
3813
| test.go:86:13:86:25 | call to Cookies : slice type | test.go:87:16:87:31 | selection of Value |
39-
| test.go:87:16:87:25 | implicit dereference : Cookie | test.go:87:16:87:25 | implicit dereference : Cookie |
40-
| test.go:87:16:87:25 | implicit dereference : Cookie | test.go:87:16:87:25 | index expression : pointer type |
41-
| test.go:87:16:87:25 | implicit dereference : Cookie | test.go:87:16:87:31 | selection of Value |
42-
| test.go:87:16:87:25 | index expression : pointer type | test.go:87:16:87:25 | implicit dereference : Cookie |
43-
| test.go:87:16:87:25 | index expression : pointer type | test.go:87:16:87:25 | index expression : pointer type |
44-
| test.go:87:16:87:25 | index expression : pointer type | test.go:87:16:87:31 | selection of Value |
4514
| test.go:97:11:97:15 | &... : pointer type | test.go:98:16:98:21 | selection of s |
4615
| test.go:111:21:111:42 | call to Param : string | test.go:112:16:112:42 | type assertion |
4716
| test.go:122:11:122:32 | call to Param : string | test.go:123:16:123:20 | param |
@@ -67,21 +36,12 @@ nodes
6736
| test.go:55:2:55:46 | ... := ...[0] : pointer type | semmle.label | ... := ...[0] : pointer type |
6837
| test.go:59:20:59:25 | buffer | semmle.label | buffer |
6938
| test.go:64:2:64:31 | ... := ...[0] : pointer type | semmle.label | ... := ...[0] : pointer type |
70-
| test.go:65:16:65:19 | implicit dereference : Form | semmle.label | implicit dereference : Form |
71-
| test.go:65:16:65:25 | selection of Value : map type | semmle.label | selection of Value : map type |
72-
| test.go:65:16:65:38 | index expression : slice type | semmle.label | index expression : slice type |
7339
| test.go:65:16:65:41 | index expression | semmle.label | index expression |
7440
| test.go:70:2:70:31 | ... := ...[0] : pointer type | semmle.label | ... := ...[0] : pointer type |
75-
| test.go:71:16:71:19 | implicit dereference : Form | semmle.label | implicit dereference : Form |
76-
| test.go:71:16:71:24 | selection of File : map type | semmle.label | selection of File : map type |
77-
| test.go:71:16:71:40 | index expression : slice type | semmle.label | index expression : slice type |
7841
| test.go:75:20:75:25 | buffer | semmle.label | buffer |
7942
| test.go:80:2:80:32 | ... := ...[0] : pointer type | semmle.label | ... := ...[0] : pointer type |
80-
| test.go:81:16:81:18 | implicit dereference : Cookie | semmle.label | implicit dereference : Cookie |
8143
| test.go:81:16:81:24 | selection of Value | semmle.label | selection of Value |
8244
| test.go:86:13:86:25 | call to Cookies : slice type | semmle.label | call to Cookies : slice type |
83-
| test.go:87:16:87:25 | implicit dereference : Cookie | semmle.label | implicit dereference : Cookie |
84-
| test.go:87:16:87:25 | index expression : pointer type | semmle.label | index expression : pointer type |
8545
| test.go:87:16:87:31 | selection of Value | semmle.label | selection of Value |
8646
| test.go:97:11:97:15 | &... : pointer type | semmle.label | &... : pointer type |
8747
| test.go:98:16:98:21 | selection of s | semmle.label | selection of s |

‎go/ql/test/library-tests/semmle/go/frameworks/Revel/OpenRedirect.expected‎

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,6 @@
11
edges
2-
| EndToEnd.go:94:20:94:27 | implicit dereference : Params | EndToEnd.go:94:20:94:27 | implicit dereference : Params |
3-
| EndToEnd.go:94:20:94:27 | implicit dereference : Params | EndToEnd.go:94:20:94:27 | selection of Params : pointer type |
4-
| EndToEnd.go:94:20:94:27 | implicit dereference : Params | EndToEnd.go:94:20:94:49 | call to Get |
5-
| EndToEnd.go:94:20:94:27 | selection of Params : pointer type | EndToEnd.go:94:20:94:27 | implicit dereference : Params |
6-
| EndToEnd.go:94:20:94:27 | selection of Params : pointer type | EndToEnd.go:94:20:94:27 | selection of Params : pointer type |
72
| EndToEnd.go:94:20:94:27 | selection of Params : pointer type | EndToEnd.go:94:20:94:49 | call to Get |
83
nodes
9-
| EndToEnd.go:94:20:94:27 | implicit dereference : Params | semmle.label | implicit dereference : Params |
104
| EndToEnd.go:94:20:94:27 | selection of Params : pointer type | semmle.label | selection of Params : pointer type |
115
| EndToEnd.go:94:20:94:49 | call to Get | semmle.label | call to Get |
126
subpaths

0 commit comments

Comments
 (0)