C#: Remove expression population safeguard and guard creation of constructor initializer expressions.

Author: michaelnebel

csharp/extractor/Semmle.Extraction.CSharp/Entities/Constructor.cs

@@ -60,7 +60,7 @@ protected override void ExtractInitializers(TextWriter trapFile)
             // Do not extract initializers for constructed types.
             // Extract initializers for constructors with a body, primary constructors
             // and default constructors for classes and structs declared in source code.
-            if (Block is null && ExpressionBody is null && !MakeSynthetic)
+            if (Block is null && ExpressionBody is null && !MakeSynthetic || Context.OnlyScaffold)
             {
                 return;
             }
@@ -113,6 +113,7 @@ protected override void ExtractInitializers(TextWriter trapFile)
                 }
 
                 var baseConstructorTarget = Create(Context, baseConstructor);
+
                 var info = new ExpressionInfo(Context,
                     AnnotatedTypeSymbol.CreateNotAnnotated(baseType),
                     Location,

csharp/extractor/Semmle.Extraction.CSharp/Entities/Expression.cs

@@ -34,11 +34,6 @@ internal Expression(IExpressionInfo info, bool shouldPopulate = true)
 
         protected sealed override void Populate(TextWriter trapFile)
         {
-            if (Context.OnlyScaffold)
-            {
-                return;
-            }
-
             var type = Type.HasValue ? Entities.Type.Create(Context, Type.Value) : NullType.Create(Context);
             trapFile.expressions(this, Kind, type.TypeRef);
             if (info.Parent.IsTopLevelParent)