C#: For implicit constructors, pick a unique source location as reporting location (if any).

michaelnebel · michaelnebel · commit 12dc65d170ba · 2025-10-06T14:02:13.000+02:00
diff --git a/csharp/extractor/Semmle.Extraction.CSharp/Entities/Constructor.cs b/csharp/extractor/Semmle.Extraction.CSharp/Entities/Constructor.cs
@@ -222,7 +222,8 @@ public override Microsoft.CodeAnalysis.Location? ReportingLocation
 
                 if (Symbol.IsImplicitlyDeclared)
                 {
-                    return ContainingType!.ReportingLocation;
+                    var best = Symbol.Locations.Where(l => l.IsInSource).BestOrDefault();
+                    return best ?? ContainingType!.ReportingLocation;
                 }
 
                 return Symbol.ContainingType.Locations.FirstOrDefault();

Original file line number	Diff line number	Diff line change
`@@ -222,7 +222,8 @@ public override Microsoft.CodeAnalysis.Location? ReportingLocation`
`222`	`222`
`223`	`223`	`if (Symbol.IsImplicitlyDeclared)`
`224`	`224`	`{`
`225`		`- return ContainingType!.ReportingLocation;`
	`225`	`+ var best = Symbol.Locations.Where(l => l.IsInSource).BestOrDefault();`
	`226`	`+ return best ?? ContainingType!.ReportingLocation;`
`226`	`227`	`}`
`227`	`228`
`228`	`229`	`return Symbol.ContainingType.Locations.FirstOrDefault();`