C++: Minor textual fixes

Author: jketema

cpp/downgrades/2e2d805ef93d060b813403cb9b51dc72455a4c68/upgrade.properties

@@ -1,4 +1,4 @@
-description: add `isDesignatorInit`predicate to `ArrayOrVectorAggregateLiteral` and `ClassAggregateLiteral`
+description: add `hasDesignator` predicate to `ArrayOrVectorAggregateLiteral` and `ClassAggregateLiteral`
 compatibility: backwards
 aggregate_array_init.rel: run aggregate_array_init.qlo
-aggregate_field_init.rel: run aggregate_field_init.qlo
+aggregate_field_init.rel: run aggregate_field_init.qlo

cpp/ql/lib/change-notes/2025-04-15-field-array-designator.md

@@ -1,4 +1,4 @@
 ---
 category: feature
 ---
-* Introduced `isDesignatorInit()` predicates to distinguish between designator-based and positional initializations for both struct/union fields and array elements.
+* Introduced `hasDesignator()` predicates to distinguish between designated and positional initializations for both struct/union fields and array elements.

cpp/ql/lib/semmle/code/cpp/exprs/Literal.qll

@@ -218,20 +218,17 @@ class ClassAggregateLiteral extends AggregateLiteral {
 
   /**
    * Holds if the `position`-th initialization of `field` in this aggregate initializer
-   * uses a designator (e.g., `.x =`, `[42] =`) rather than a positional initializer.
+   * uses a designated (e.g., `.x = ...`) rather than a positional initializer.
    *
-   * This can be used to distinguish explicitly designated initializations from
-   * implicit positional ones.
-   *
-   * For example, in the initializer:
+   * For example, in:
    * ```c
    * struct S { int x, y; };
    * struct S s = { .x = 1, 2 };
    * ```
-   * - `.x = 1` is a designator init, therefore `isDesignatorInit(x, 0)` holds.
-   * - `2` is a positional init for `.y`, therefore `isDesignatorInit(y, 1)` does **not** hold.
+   * - `.x = 1` is a designated initializer, therefore `hasDesignator(x, 0)` holds.
+   * - `2` is a positional initializer for `s.y`, therefore `hasDesignator(y, 1)` does not hold.
    */
-  predicate isDesignatorInit(Field field, int position) {
+  predicate hasDesignator(Field field, int position) {
     field = classType.getAField() and
     aggregate_field_init(underlyingElement(this), _, unresolveElement(field), position, true)
   }
@@ -330,17 +327,17 @@ class ArrayOrVectorAggregateLiteral extends AggregateLiteral {
 
   /**
    * Holds if the `position`-th initialization of the array element at `elementIndex`
-   * in this aggregate initializer uses a designator (e.g., `[0] = ...`) rather than
-   * an implicit positional initializer.
+   * in this aggregate initializer uses a designated (e.g., `[0] = ...`) rather than
+   * a positional initializer.
    *
    * For example, in:
    * ```c
    * int x[] = { [0] = 1, 2 };
    * ```
-   * - `[0] = 1` is a designator init, therefore `isDesignatorInit(0, 0)` holds.
-   * - `2` is a positional init for `x[1]`, therefore `isDesignatorInit(1, 1)` does **not** hold.
+   * - `[0] = 1` is a designated initializer, therefore `hasDesignator(0, 0)` holds.
+   * - `2` is a positional initializer for `x[1]`, therefore `hasDesignator(1, 1)` does not hold.
    */
-  predicate isDesignatorInit(int elementIndex, int position) {
+  predicate hasDesignator(int elementIndex, int position) {
     aggregate_array_init(underlyingElement(this), _, elementIndex, position, true)
   }
 

cpp/ql/lib/upgrades/0f0a390468a5eb43d1dc72937c028070b106bf53/upgrade.properties

@@ -1,4 +1,4 @@
-description: add `isDesignatorInit`predicate to `ArrayOrVectorAggregateLiteral` and `ClassAggregateLiteral`
+description: add `hasDesignator` predicate to `ArrayOrVectorAggregateLiteral` and `ClassAggregateLiteral`
 compatibility: backwards
 aggregate_array_init.rel: run aggregate_array_init.qlo
-aggregate_field_init.rel: run aggregate_field_init.qlo
+aggregate_field_init.rel: run aggregate_field_init.qlo