File tree Expand file tree Collapse file tree 2 files changed +24
-0
lines changed
cpp/ql/test/query-tests/Best Practices/SloppyGlobal Expand file tree Collapse file tree 2 files changed +24
-0
lines changed Original file line number Diff line number Diff line change 11| main.cpp:3:5:3:5 | x | Poor global variable name 'x'. Prefer longer, descriptive names for globals (eg. kMyGlobalConstant, not foo). |
22| main.cpp:4:5:4:6 | ys | Poor global variable name 'ys'. Prefer longer, descriptive names for globals (eg. kMyGlobalConstant, not foo). |
3+ | main.cpp:9:5:9:6 | v1 | Poor global variable name 'v1'. Prefer longer, descriptive names for globals (eg. kMyGlobalConstant, not foo). |
4+ | main.cpp:10:5:10:6 | v2 | Poor global variable name 'v2'. Prefer longer, descriptive names for globals (eg. kMyGlobalConstant, not foo). |
5+ | main.cpp:12:5:12:5 | v3 | Poor global variable name 'v3'. Prefer longer, descriptive names for globals (eg. kMyGlobalConstant, not foo). |
6+ | main.cpp:14:3:14:3 | v4 | Poor global variable name 'v4'. Prefer longer, descriptive names for globals (eg. kMyGlobalConstant, not foo). |
7+ | main.cpp:14:5:14:5 | v4 | Poor global variable name 'v4'. Prefer longer, descriptive names for globals (eg. kMyGlobalConstant, not foo). |
8+ | main.cpp:16:3:16:3 | v5 | Poor global variable name 'v5'. Prefer longer, descriptive names for globals (eg. kMyGlobalConstant, not foo). |
9+ | main.cpp:16:3:16:3 | v5 | Poor global variable name 'v5'. Prefer longer, descriptive names for globals (eg. kMyGlobalConstant, not foo). |
10+ | main.cpp:16:5:16:5 | v5 | Poor global variable name 'v5'. Prefer longer, descriptive names for globals (eg. kMyGlobalConstant, not foo). |
Original file line number Diff line number Diff line change @@ -5,3 +5,19 @@ int ys[1000000]; // BAD: too short
55int descriptive_name; // GOOD: sufficient
66
77static int z; // GOOD: not a global
8+
9+ int v1;
10+ int v2;
11+ template <typename T>
12+ T v3;
13+ template <typename T>
14+ T v4;
15+ template <typename T>
16+ T v5;
17+
18+ void use_some_fs () {
19+ v2 = 100 ;
20+ v4<int > = 200 ;
21+ v5<int > = 300 ;
22+ v5<const char *> = " string" ;
23+ }
You can’t perform that action at this time.
0 commit comments