Skip to content

Commit 093b04f

Browse files
Update comments
1 parent 696ec29 commit 093b04f

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

java/ql/src/Security/CWE/CWE-1004/SensitiveCookieNotHttpOnly.ql

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -14,9 +14,9 @@
1414
* Sketch of the structure of this query: we track cookie names that appear to be sensitive
1515
* (e.g. `session` or `token`) to a `ServletResponse.addHeader(...)` or `.addCookie(...)`
1616
* method that does not set the `httpOnly` flag. Subsidiary configurations
17-
* `MatchesHttpOnlyToRawHeaderConfiguration` and `SetHttpOnlyInCookieConfiguration` are used to establish
17+
* `MatchesHttpOnlyToRawHeaderConfig` and `SetHttpOnlyInCookieConfig` are used to establish
1818
* when the `httpOnly` flag is likely to have been set, before configuration
19-
* `MissingHttpOnlyConfiguration` establishes that a non-`httpOnly` cookie has a sensitive-seeming name.
19+
* `MissingHttpOnlyConfig` establishes that a non-`httpOnly` cookie has a sensitive-seeming name.
2020
*/
2121

2222
import java
@@ -158,8 +158,8 @@ predicate setsHttpOnlyInNewCookie(ClassInstanceExpr cie) {
158158
/**
159159
* A taint configuration tracking flow from a sensitive cookie without the `HttpOnly` flag
160160
* set to its HTTP response.
161-
* Tracks string literals containing sensitive names (`SensitiveNameExpr`), to an `addCookie` call (as a `Cookie` object)
162-
* or an `addHeader` call (as a string) (`CookieResponseWithoutHttpOnly`).
161+
* Tracks string literals containing sensitive names (`SensitiveCookieNameExpr`), to an `addCookie` call (as a `Cookie` object)
162+
* or an `addHeader` call (as a string) (`CookieResponseWithoutHttpOnlySink`).
163163
* Passes through `Cookie` constructors and `toString` calls.
164164
*/
165165
module MissingHttpOnlyConfig implements DataFlow::ConfigSig {

0 commit comments

Comments
 (0)