Merge pull request #13916 from erik-krogh/limit-java-field-reg

erik-krogh · web-flow · commit 08ef31d452c8 · 2023-08-18T12:14:31.000+02:00
Java: limit field flow when tracking regex strings
diff --git a/java/ql/lib/semmle/code/java/regex/RegexFlowConfigs.qll b/java/ql/lib/semmle/code/java/regex/RegexFlowConfigs.qll
@@ -148,6 +148,8 @@ private module RegexFlowConfig implements DataFlow::ConfigSig {
   predicate isBarrier(DataFlow::Node node) {
     node.getEnclosingCallable().getDeclaringType() instanceof NonSecurityTestClass
   }
+
+  int fieldFlowBranchLimit() { result = 1 }
 }
 
 private module RegexFlow = DataFlow::Global<RegexFlowConfig>;

Original file line number	Diff line number	Diff line change
`@@ -148,6 +148,8 @@ private module RegexFlowConfig implements DataFlow::ConfigSig {`
`148`	`148`	`predicate isBarrier(DataFlow::Node node) {`
`149`	`149`	`node.getEnclosingCallable().getDeclaringType() instanceof NonSecurityTestClass`
`150`	`150`	`}`
	`151`	`+`
	`152`	`+ int fieldFlowBranchLimit() { result = 1 }`
`151`	`153`	`}`
`152`	`154`
`153`	`155`	`private module RegexFlow = DataFlow::Global<RegexFlowConfig>;`