Merge pull request #16968 from tamasvajk/feature/buildless-deterministic-file-order-2

C#: Order syntax trees before creating compilation

Author: tamasvajk

csharp/extractor/Semmle.Extraction.CSharp.DependencyFetching/FileProvider.cs

@@ -62,7 +62,7 @@ private string[] SelectTextFileNamesByExtension(string filetype, params string[]
         private string[] SelectTextFileNamesByName(string name)
         {
             var ret = allNonBinary.Value.SelectFileNamesByName(name).ToArray();
-            var ending = ret.Length == 0 ? "." : $": {string.Join(", ", ret)}.";
+            var ending = ret.Length == 0 ? "." : $": {string.Join(", ", ret.OrderBy(s => s))}.";
             logger.LogInfo($"Found {ret.Length} {name} files in {SourceDir}{ending}");
             return ret;
         }
@@ -91,9 +91,7 @@ private IEnumerable<FileInfo> SelectSmallFiles(IEnumerable<FileInfo> files)
         private FileInfo[] GetAllFiles()
         {
             logger.LogInfo($"Finding files in {SourceDir}...");
-            var files = SourceDir
-                .GetFiles("*.*", new EnumerationOptions { RecurseSubdirectories = true })
-                .OrderBy(f => f.FullName);
+            var files = SourceDir.GetFiles("*.*", new EnumerationOptions { RecurseSubdirectories = true });
 
             var filteredFiles = files.Where(f =>
             {

csharp/extractor/Semmle.Extraction.CSharp/Extractor/Extractor.cs

@@ -435,6 +435,8 @@ public static ExitCode Analyse(Stopwatch stopwatch, Analyser analyser, CommonOpt
                 }
             }
 
+            syntaxTrees.Sort((a, b) => string.Compare(a.FilePath, b.FilePath, StringComparison.Ordinal));
+
             var compilation = getCompilation(syntaxTrees, references);
 
             initializeAnalyser(compilation, options);