apply suggestions from review

Author: erik-krogh

ruby/ql/lib/codeql/ruby/security/CommandInjectionCustomizations.qll

@@ -33,7 +33,7 @@ module CommandInjection {
   class RemoteFlowSourceAsSource extends Source {
     RemoteFlowSourceAsSource() { this instanceof RemoteFlowSource }
 
-    override string getSourceType() { result = "a user-provided value" }
+    override string getSourceType() { result = "user-provided value" }
   }
 
   /**

ruby/ql/src/experimental/cwe-807/ConditionalBypass.ql

@@ -78,5 +78,5 @@ predicate isTaintedGuardForSensitiveAction(
 
 from DataFlow::PathNode source, DataFlow::PathNode sink, SensitiveAction action
 where isTaintedGuardForSensitiveAction(sink, source, action)
-select sink.getNode(), source, sink, "This condition guards a sensitive $@, but $@ controls it.",
-  action, "action", source.getNode(), "a user-provided value"
+select sink.getNode(), source, sink, "This condition guards a sensitive $@, but a $@ controls it.",
+  action, "action", source.getNode(), "user-provided value"

ruby/ql/src/queries/security/cwe-022/PathInjection.ql

@@ -22,5 +22,5 @@ import DataFlow::PathGraph
 
 from Configuration cfg, DataFlow::PathNode source, DataFlow::PathNode sink
 where cfg.hasFlowPath(source, sink)
-select sink.getNode(), source, sink, "This path depends on $@.", source.getNode(),
-  "a user-provided value"
+select sink.getNode(), source, sink, "This path depends on a $@.", source.getNode(),
+  "user-provided value"

ruby/ql/src/queries/security/cwe-078/CommandInjection.ql

@@ -21,5 +21,5 @@ from Configuration config, DataFlow::PathNode source, DataFlow::PathNode sink, S
 where
   config.hasFlowPath(source, sink) and
   sourceNode = source.getNode()
-select sink.getNode(), source, sink, "This command depends on $@.", sourceNode,
+select sink.getNode(), source, sink, "This command depends on a $@.", sourceNode,
   sourceNode.getSourceType()

ruby/ql/src/queries/security/cwe-079/ReflectedXSS.ql

@@ -19,5 +19,5 @@ import DataFlow::PathGraph
 
 from ReflectedXss::Configuration config, DataFlow::PathNode source, DataFlow::PathNode sink
 where config.hasFlowPath(source, sink)
-select sink.getNode(), source, sink, "Cross-site scripting vulnerability due to $@.",
-  source.getNode(), "a user-provided value"
+select sink.getNode(), source, sink, "Cross-site scripting vulnerability due to a $@.",
+  source.getNode(), "user-provided value"

ruby/ql/src/queries/security/cwe-089/SqlInjection.ql

@@ -34,5 +34,5 @@ class SqlInjectionConfiguration extends TaintTracking::Configuration {
 
 from SqlInjectionConfiguration config, DataFlow::PathNode source, DataFlow::PathNode sink
 where config.hasFlowPath(source, sink)
-select sink.getNode(), source, sink, "This SQL query depends on $@.", source.getNode(),
-  "a user-provided value"
+select sink.getNode(), source, sink, "This SQL query depends on a $@.", source.getNode(),
+  "user-provided value"

ruby/ql/src/queries/security/cwe-094/CodeInjection.ql

@@ -22,5 +22,5 @@ from Configuration config, DataFlow::PathNode source, DataFlow::PathNode sink, S
 where
   config.hasFlowPath(source, sink) and
   sourceNode = source.getNode()
-select sink.getNode(), source, sink, "This code execution depends on $@.", source.getNode(),
-  "a user-provided value"
+select sink.getNode(), source, sink, "This code execution depends on a $@.", source.getNode(),
+  "user-provided value"

ruby/ql/src/queries/security/cwe-117/LogInjection.ql

@@ -17,5 +17,5 @@ import codeql.ruby.security.LogInjectionQuery
 
 from LogInjectionConfiguration config, DataFlow::PathNode source, DataFlow::PathNode sink
 where config.hasFlowPath(source, sink)
-select sink.getNode(), source, sink, "Log entry depends on $@.", source.getNode(),
-  "a user-provided value"
+select sink.getNode(), source, sink, "Log entry depends on a $@.", source.getNode(),
+  "user-provided value"

ruby/ql/src/queries/security/cwe-1333/PolynomialReDoS.ql

@@ -26,6 +26,6 @@ where
   sinkNode = sink.getNode() and
   regexp = sinkNode.getRegExp()
 select sinkNode.getHighlight(), source, sink,
-  "This $@ that depends on $@ may run slow on strings " + regexp.getPrefixMessage() +
+  "This $@ that depends on a $@ may run slow on strings " + regexp.getPrefixMessage() +
     "with many repetitions of '" + regexp.getPumpString() + "'.", regexp, "regular expression",
-  source.getNode(), "a user-provided value"
+  source.getNode(), "user-provided value"

ruby/ql/src/queries/security/cwe-1333/RegExpInjection.ql

@@ -22,5 +22,5 @@ import codeql.ruby.security.regexp.RegExpInjectionQuery
 
 from Configuration cfg, DataFlow::PathNode source, DataFlow::PathNode sink
 where cfg.hasFlowPath(source, sink)
-select sink.getNode(), source, sink, "This regular expression depends on $@.", source.getNode(),
-  "a user-provided value"
+select sink.getNode(), source, sink, "This regular expression depends on a $@.", source.getNode(),
+  "user-provided value"