C#: Only extract the unbound location for fields and parameters and use this location in the QL code.

Author: michaelnebel

csharp/extractor/Semmle.Extraction.CSharp/Entities/Field.cs

@@ -49,7 +49,10 @@ public override void Populate(TextWriter trapFile)
                 }
             }
 
-            WriteLocationsToTrap(trapFile.field_location, this, Locations);
+            if (Context.ExtractLocation(Symbol))
+            {
+                WriteLocationsToTrap(trapFile.field_location, this, Locations);
+            }
 
             if (!IsSourceDeclaration || !Symbol.FromSource())
                 return;

csharp/extractor/Semmle.Extraction.CSharp/Entities/Parameter.cs

@@ -115,9 +115,10 @@ public override void Populate(TextWriter trapFile)
             var type = Type.Create(Context, Symbol.Type);
             trapFile.@params(this, Name, type.TypeRef, Ordinal, ParamKind, Parent!, Original);
 
-            foreach (var l in Symbol.Locations)
+            if (Context.ExtractLocation(Symbol))
             {
-                WriteLocationToTrap(trapFile.param_location, this, Context.CreateLocation(l));
+                var locations = Context.GetLocations(Symbol);
+                WriteLocationsToTrap(trapFile.param_location, this, locations);
             }
 
             if (!Symbol.Locations.Any() &&

csharp/ql/lib/semmle/code/csharp/Variable.qll

@@ -213,7 +213,7 @@ class Parameter extends LocalScopeVariable, Attributable, TopLevelExprParent, @p
     params(this, _, getTypeRef(result), _, _, _, _)
   }
 
-  override Location getALocation() { param_location(this, result) }
+  override Location getALocation() { param_location(this.getUnboundDeclaration(), result) }
 
   override string toString() { result = this.getName() }
 
@@ -449,7 +449,7 @@ class Field extends Variable, AssignableMember, Attributable, TopLevelExprParent
     fields(this, _, _, _, getTypeRef(result), _)
   }
 
-  override Location getALocation() { field_location(this, result) }
+  override Location getALocation() { field_location(this.getUnboundDeclaration(), result) }
 
   override string toString() { result = Variable.super.toString() }