C#: Minor cleanup in the Pattern files.

michaelnebel · michaelnebel · commit 0230b8b56f5d · 2022-12-16T08:24:09.000+01:00
diff --git a/csharp/extractor/Semmle.Extraction.CSharp/Entities/Expressions/Patterns/BinaryPattern.cs b/csharp/extractor/Semmle.Extraction.CSharp/Entities/Expressions/Patterns/BinaryPattern.cs
@@ -1,7 +1,6 @@
 using Microsoft.CodeAnalysis;
 using Microsoft.CodeAnalysis.CSharp;
 using Microsoft.CodeAnalysis.CSharp.Syntax;
-using Semmle.Extraction.Entities;
 using Semmle.Extraction.Kinds;
 
 namespace Semmle.Extraction.CSharp.Entities.Expressions
diff --git a/csharp/extractor/Semmle.Extraction.CSharp/Entities/Expressions/Patterns/Pattern.cs b/csharp/extractor/Semmle.Extraction.CSharp/Entities/Expressions/Patterns/Pattern.cs
@@ -1,7 +1,6 @@
 using Microsoft.CodeAnalysis;
 using Microsoft.CodeAnalysis.CSharp.Syntax;
 using Microsoft.CodeAnalysis.CSharp;
-using Semmle.Extraction.Entities;
 
 namespace Semmle.Extraction.CSharp.Entities.Expressions
 {
diff --git a/csharp/extractor/Semmle.Extraction.CSharp/Entities/Expressions/Patterns/PositionalPattern.cs b/csharp/extractor/Semmle.Extraction.CSharp/Entities/Expressions/Patterns/PositionalPattern.cs
@@ -1,6 +1,5 @@
 using Microsoft.CodeAnalysis.CSharp.Syntax;
 using Semmle.Extraction.Kinds;
-using Semmle.Extraction.Entities;
 
 namespace Semmle.Extraction.CSharp.Entities.Expressions
 {
@@ -12,7 +11,7 @@ internal PositionalPattern(Context cx, PositionalPatternClauseSyntax posPc, IExp
             child = 0;
             foreach (var sub in posPc.Subpatterns)
             {
-                Expressions.Pattern.Create(cx, sub.Pattern, this, child++);
+                Pattern.Create(cx, sub.Pattern, this, child++);
             }
         }
     }
diff --git a/csharp/extractor/Semmle.Extraction.CSharp/Entities/Expressions/Patterns/PropertyPattern.cs b/csharp/extractor/Semmle.Extraction.CSharp/Entities/Expressions/Patterns/PropertyPattern.cs
@@ -1,8 +1,6 @@
-using System;
 using System.Collections.Generic;
 using Microsoft.CodeAnalysis.CSharp.Syntax;
 using Semmle.Extraction.Kinds;
-using Semmle.Extraction.Entities;
 
 namespace Semmle.Extraction.CSharp.Entities.Expressions
 {
@@ -27,7 +25,7 @@ private record AccessStep(string Identifier, Microsoft.CodeAnalysis.Location Loc
 
         private class AccessStepPack
         {
-            public readonly List<AccessStep> Prefix = new List<AccessStep>();
+            public readonly List<AccessStep> Prefix = new();
             public AccessStep Last { get; private set; }
 
             public AccessStepPack Add(string identifier, Microsoft.CodeAnalysis.Location location)
diff --git a/csharp/extractor/Semmle.Extraction.CSharp/Entities/Expressions/Patterns/RecursivePattern.cs b/csharp/extractor/Semmle.Extraction.CSharp/Entities/Expressions/Patterns/RecursivePattern.cs
@@ -2,7 +2,6 @@
 using Microsoft.CodeAnalysis.CSharp.Syntax;
 using Microsoft.CodeAnalysis.CSharp;
 using Semmle.Extraction.Kinds;
-using Semmle.Extraction.Entities;
 
 namespace Semmle.Extraction.CSharp.Entities.Expressions
 {
diff --git a/csharp/extractor/Semmle.Extraction.CSharp/Entities/Expressions/Patterns/RelationalPattern.cs b/csharp/extractor/Semmle.Extraction.CSharp/Entities/Expressions/Patterns/RelationalPattern.cs
@@ -2,7 +2,6 @@
 using Microsoft.CodeAnalysis.CSharp.Syntax;
 using Microsoft.CodeAnalysis.CSharp;
 using Semmle.Extraction.Kinds;
-using Semmle.Extraction.Entities;
 
 namespace Semmle.Extraction.CSharp.Entities.Expressions
 {
diff --git a/csharp/extractor/Semmle.Extraction.CSharp/Entities/Expressions/Patterns/UnaryPattern.cs b/csharp/extractor/Semmle.Extraction.CSharp/Entities/Expressions/Patterns/UnaryPattern.cs
@@ -1,5 +1,4 @@
 using Microsoft.CodeAnalysis.CSharp.Syntax;
-using Semmle.Extraction.Entities;
 using Semmle.Extraction.Kinds;
 
 namespace Semmle.Extraction.CSharp.Entities.Expressions

Original file line number	Diff line number	Diff line change
`@@ -1,7 +1,6 @@`
`1`	`1`	`using Microsoft.CodeAnalysis;`
`2`	`2`	`using Microsoft.CodeAnalysis.CSharp.Syntax;`
`3`	`3`	`using Microsoft.CodeAnalysis.CSharp;`
`4`		`-using Semmle.Extraction.Entities;`
`5`	`4`
`6`	`5`	`namespace Semmle.Extraction.CSharp.Entities.Expressions`
`7`	`6`	`{`
Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,5 @@`
`1`	`1`	`using Microsoft.CodeAnalysis.CSharp.Syntax;`
`2`	`2`	`using Semmle.Extraction.Kinds;`
`3`		`-using Semmle.Extraction.Entities;`
`4`	`3`
`5`	`4`	`namespace Semmle.Extraction.CSharp.Entities.Expressions`
`6`	`5`	`{`
`@@ -12,7 +11,7 @@ internal PositionalPattern(Context cx, PositionalPatternClauseSyntax posPc, IExp`
`12`	`11`	`child = 0;`
`13`	`12`	`foreach (var sub in posPc.Subpatterns)`
`14`	`13`	`{`
`15`		`- Expressions.Pattern.Create(cx, sub.Pattern, this, child++);`
	`14`	`+ Pattern.Create(cx, sub.Pattern, this, child++);`
`16`	`15`	`}`
`17`	`16`	`}`
`18`	`17`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1,8 +1,6 @@`
`1`		`-using System;`
`2`	`1`	`using System.Collections.Generic;`
`3`	`2`	`using Microsoft.CodeAnalysis.CSharp.Syntax;`
`4`	`3`	`using Semmle.Extraction.Kinds;`
`5`		`-using Semmle.Extraction.Entities;`
`6`	`4`
`7`	`5`	`namespace Semmle.Extraction.CSharp.Entities.Expressions`
`8`	`6`	`{`
`@@ -27,7 +25,7 @@ private record AccessStep(string Identifier, Microsoft.CodeAnalysis.Location Loc`
`27`	`25`
`28`	`26`	`private class AccessStepPack`
`29`	`27`	`{`
`30`		`- public readonly List<AccessStep> Prefix = new List<AccessStep>();`
	`28`	`+ public readonly List<AccessStep> Prefix = new();`
`31`	`29`	`public AccessStep Last { get; private set; }`
`32`	`30`
`33`	`31`	`public AccessStepPack Add(string identifier, Microsoft.CodeAnalysis.Location location)`
Original file line number	Diff line number	Diff line change
`@@ -2,7 +2,6 @@`
`2`	`2`	`using Microsoft.CodeAnalysis.CSharp.Syntax;`
`3`	`3`	`using Microsoft.CodeAnalysis.CSharp;`
`4`	`4`	`using Semmle.Extraction.Kinds;`
`5`		`-using Semmle.Extraction.Entities;`
`6`	`5`
`7`	`6`	`namespace Semmle.Extraction.CSharp.Entities.Expressions`
`8`	`7`	`{`
Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,4 @@`
`1`	`1`	`using Microsoft.CodeAnalysis.CSharp.Syntax;`
`2`		`-using Semmle.Extraction.Entities;`
`3`	`2`	`using Semmle.Extraction.Kinds;`
`4`	`3`
`5`	`4`	`namespace Semmle.Extraction.CSharp.Entities.Expressions`