Skip to content

IOFStreamMissingPositioning: Improve performance #860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 5, 2025
Merged

IOFStreamMissingPositioning: Improve performance #860

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0b59317
A27-0-3: Improve performance
lcartey Feb 17, 2025
9edacca
Merge branch 'main' into lcartey/iofstream-performance
knewbury01 Mar 4, 2025
614c7ab
Update change_notes/2025-02-17-iofstream-performance.md
lcartey Mar 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions change_notes/2025-02-17-iofstream-performance.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
- `A27-0-3`, `FIO309-C` `FIO50-CPP`, `RULE-30-0-2` - `InterleavedInputOutputWithoutFlush.ql`, `DoNotAlternatelyIOFromStreamWithoutPositioning.ql`,`InterleavedInputOutputWithoutPosition.ql`, `ReadsAndWritesOnStreamNotSeparatedByPositioning.ql`:
- Reduce evaluation time on complex codebases.
4 changes: 3 additions & 1 deletion ...src/codingstandards/cpp/rules/iofstreammissingpositioning/IOFstreamMissingPositioning.qll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,17 +57,19 @@ predicate sameSource(FunctionCall a, FunctionCall b) {
sameFileSource(a, b)
}

bindingset[a, b]
predicate sameAccessDirection(ReadWriteCall a, ReadWriteCall b) {
a.getAccessDirection() = b.getAccessDirection()
}

bindingset[a, b]
predicate oppositeAccessDirection(ReadWriteCall a, ReadWriteCall b) {
not sameAccessDirection(a, b)
}

/**
* A write operation reaching a read and vice versa
* without intervening filepositioning
* without intervening file positioning calls.
*/
ControlFlowNode reachesInExOperator(ReadWriteCall op) {
result = op
Expand Down
Loading