IdentifierHidden: omit types

Author: knewbury01

cpp/common/src/codingstandards/cpp/Scope.qll

@@ -71,6 +71,7 @@ class UserDeclaration extends Declaration {
     not this instanceof ClassTemplateInstantiation and
     // compiler inferred parameters have name of p#0
     not this.(Parameter).getName() = "p#0"
+    and not this instanceof Type
   }
 }
 

cpp/common/test/rules/identifierhidden/IdentifierHidden.expected

@@ -1,6 +1,5 @@
 | test.cpp:4:5:4:7 | id1 | Declaration is hiding declaration $@. | test.cpp:1:5:1:7 | id1 | id1 |
 | test.cpp:8:5:8:7 | id1 | Declaration is hiding declaration $@. | test.cpp:1:5:1:7 | id1 | id1 |
-| test.cpp:11:5:11:7 | id1 | Declaration is hiding declaration $@. | test.cpp:8:5:8:7 | id1 | id1 |
 | test.cpp:20:7:20:9 | id1 | Declaration is hiding declaration $@. | test.cpp:1:5:1:7 | id1 | id1 |
 | test.cpp:23:13:23:15 | id1 | Declaration is hiding declaration $@. | test.cpp:1:5:1:7 | id1 | id1 |
 | test.cpp:26:12:26:14 | id1 | Declaration is hiding declaration $@. | test.cpp:1:5:1:7 | id1 | id1 |
@@ -10,4 +9,3 @@
 | test.cpp:70:12:70:12 | i | Declaration is hiding declaration $@. | test.cpp:61:7:61:7 | i | i |
 | test.cpp:75:16:75:16 | i | Declaration is hiding declaration $@. | test.cpp:61:7:61:7 | i | i |
 | test.cpp:81:5:81:5 | a | Declaration is hiding declaration $@. | test.cpp:79:5:79:5 | a | a |
-| test.cpp:85:13:85:13 | a | Declaration is hiding declaration $@. | test.cpp:79:5:79:5 | a | a |

cpp/common/test/rules/identifierhidden/test.cpp

@@ -82,7 +82,7 @@ int a() {} // NON_COMPLIANT
 } // namespace b
 
 namespace b1 {
-typedef int a; // NON_COMPLIANT
+typedef int a; // COMPLIANT - do not consider types
 }
 
 namespace ns_exception1_outer {