Address review comments

Author: lcartey

change_notes/2024-06-07-m0-1-3-uninstantiated-templates.md

@@ -0,0 +1,2 @@
+ - `M0-1-3` - `UnusedGlobalOrNamespaceVariable.ql`
+   - Reduces false positives by excluding compiler generated variables, and variables in uninstantiated templates.

cpp/autosar/test/rules/M0-1-3/test.cpp

@@ -83,7 +83,7 @@ template <bool... Args> extern constexpr bool all_of_v = true; // COMPLIANT
 
 template <bool B1, bool... Args>
 extern constexpr bool all_of_v<B1, Args...> =
-    B1 && all_of_v<Args...>; // COMPLIANT
+    B1 &&all_of_v<Args...>; // COMPLIANT
 
 void test_template_variable() { all_of_v<true, true, true>; }
 

cpp/common/src/codingstandards/cpp/deadcode/UnusedVariables.qll

@@ -48,12 +48,11 @@ class PotentiallyUnusedLocalVariable extends LocalVariable {
       not exists(AsmStmt s | f = s.getEnclosingFunction()) and
       // Ignore functions with error expressions as they indicate expressions that the extractor couldn't process
       not any(ErrorExpr e).getEnclosingFunction() = f
-    )
-    // ) and
-    // // exclude uninstantiated template members
-    // not this.isFromUninstantiatedTemplate(_) and
-    // // Do not report compiler generated variables
-    // not this.isCompilerGenerated()
+    ) and
+    // exclude uninstantiated template members
+    not this.isFromUninstantiatedTemplate(_) and
+    // Do not report compiler generated variables
+    not this.isCompilerGenerated()
   }
 }