Merge pull request #348 from rak3-sh/rp/a5-1-3-false-positives-fix

Fix for A5-1-3 false positives

Author: lcartey

change_notes/2023-07-11-lambda-expr-without-param-list.md

@@ -0,0 +1 @@
+ - `A5-1-3` - Only consider lambdas that have zero arguments, since any lambda with non-zero arguments will have an explicit argument list. 

cpp/autosar/src/rules/A5-1-3/LambdaExpressionWithoutParameterList.ql

@@ -21,6 +21,10 @@ where
   not isExcluded(lambda, LambdasPackage::lambdaExpressionWithoutParameterListQuery()) and
   lambdaFunction = lambda.getLambdaFunction() and
   not lambdaFunction.isAffectedByMacro() and
+  // If it has a parameter, then it will have an
+  // explicit parameter list. Therefore, proceed to check only if the lambda
+  // does not have any parameters.
+  not exists (lambdaFunction.getAParameter()) and
   // The extractor doesn't store the syntactic information whether the parameter list
   // is enclosed in parenthesis. Therefore we cannot determine if the parameter list is
   // explicitly specified when the parameter list is empty.

cpp/autosar/test/rules/A5-1-3/test.cpp

@@ -28,4 +28,11 @@ void test() {
     l1 += 1;
   };
   // clang-format on
-}
+}
+
+#define PARAM_MACRO [](int i) { i; };
+
+int test_lambda_in_macro() {
+  PARAM_MACRO // COMPLIANT
+      return 0;
+}