RULE-21-8: Simplify alert message, remove stdlib.h

Author: lcartey

c/misra/src/rules/RULE-21-8/TerminationFunctionsOfStdlibhUsed.ql

@@ -26,4 +26,4 @@ from FunctionCall fc, BannedFunction f
 where
   not isExcluded(fc, BannedPackage::terminationFunctionsOfStdlibhUsedQuery()) and
   f = fc.getTarget()
-select fc, "Call to banned function $@.", f, f.getName()
+select fc, "Call to banned function " + f.getName() + "."

c/misra/src/rules/RULE-21-8/TerminationMacrosOfStdlibhUsed.ql

@@ -23,4 +23,4 @@ from MacroInvocation mi, BannedMacro m
 where
   not isExcluded(mi, BannedPackage::terminationMacrosOfStdlibhUsedQuery()) and
   m.getAnInvocation() = mi
-select mi, "Use of banned macro $@.", m, m.getName()
+select mi, "Use of banned macro " + m.getName() + "."

c/misra/test/rules/RULE-21-8/TerminationFunctionsOfStdlibhUsed.expected

@@ -1,6 +1,6 @@
-| test.c:10:3:10:6 | call to exit | Call to banned function $@. | stdlib.h:46:16:46:19 | exit | exit |
-| test.c:11:3:11:8 | call to system | Call to banned function $@. | stdlib.h:53:5:53:10 | system | system |
-| test.c:12:3:12:7 | call to abort | Call to banned function $@. | stdlib.h:44:16:44:20 | abort | abort |
-| test.c:14:3:14:9 | call to exit | Call to banned function $@. | stdlib.h:46:16:46:19 | exit | exit |
-| test.c:15:3:15:7 | call to abort | Call to banned function $@. | stdlib.h:44:16:44:20 | abort | abort |
-| test.c:16:3:16:14 | call to system | Call to banned function $@. | stdlib.h:53:5:53:10 | system | system |
+| test.c:10:3:10:6 | call to exit | Call to banned function exit. |
+| test.c:11:3:11:8 | call to system | Call to banned function system. |
+| test.c:12:3:12:7 | call to abort | Call to banned function abort. |
+| test.c:14:3:14:9 | call to exit | Call to banned function exit. |
+| test.c:15:3:15:7 | call to abort | Call to banned function abort. |
+| test.c:16:3:16:14 | call to system | Call to banned function system. |

c/misra/test/rules/RULE-21-8/TerminationMacrosOfStdlibhUsed.expected

@@ -1,3 +1,3 @@
-| test.c:14:3:14:9 | EXIT(x) | Use of banned macro $@. | test.c:3:1:3:23 | #define EXIT(x) exit(x) | EXIT |
-| test.c:15:3:15:7 | ABORT | Use of banned macro $@. | test.c:4:1:4:21 | #define ABORT abort() | ABORT |
-| test.c:16:3:16:14 | SYSTEM(x) | Use of banned macro $@. | test.c:5:1:5:27 | #define SYSTEM(x) system(x) | SYSTEM |
+| test.c:14:3:14:9 | EXIT(x) | Use of banned macro EXIT. |
+| test.c:15:3:15:7 | ABORT | Use of banned macro ABORT. |
+| test.c:16:3:16:14 | SYSTEM(x) | Use of banned macro SYSTEM. |

c/misra/test/rules/RULE-21-8/stdlib.h

@@ -1,4 +1,4 @@
-#include "stdlib.h"
+#include <stdlib.h>
 
 #define EXIT(x) exit(x)
 #define ABORT abort()