Merge pull request #124 from jsinglet/jsinglet/rule-fix-dir-1-2

Fix Duplicate and Incorrect Rule IDs

Author: jsinglet

.github/workflows/validate-rules-csv.yml

@@ -0,0 +1,28 @@
+name: ⚙️ Validate Rules CSV
+
+on:
+  push:
+    branches:
+      - main
+      - "rc/**"
+      - next
+  pull_request:
+    branches:
+      - main
+      - "rc/**"
+      - next
+
+
+jobs:
+  validate-rules-csv:
+    name: Validate Rules CSV 
+    runs-on: ubuntu-22.04
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v2
+
+      - name: Check Rules 
+        shell: pwsh
+        run: scripts/util/Get-DuplicateRules.ps1 -Language 'all' -CIMode
+
+      

.vscode/tasks.json

@@ -185,6 +185,7 @@
             "type": "pickString",
             "options": [
                 "Allocations",
+                "Banned",
                 "BannedFunctions",
                 "BannedLibraries",
                 "BannedSyntax",

c/misra/src/rules/RULE-4-10/PrecautionIncludeGuardsNotProvided.ql renamed to c/misra/src/rules/DIR-4-10/PrecautionIncludeGuardsNotProvided.ql

@@ -1,12 +1,12 @@
 /**
  * @id c/misra/precaution-include-guards-not-provided
- * @name RULE-4-10: Precautions shall be taken in order to prevent the contents of a header file being included more than once
+ * @name DIR-4-10: Precautions shall be taken in order to prevent the contents of a header file being included more than once
  * @description Using anything other than a standard include guard form can make code confusing and
  *              can lead to multiple or conflicting definitions.
  * @kind problem
  * @precision very-high
  * @problem.severity warning
- * @tags external/misra/id/rule-4-10
+ * @tags external/misra/id/dir-4-10
  *       correctness
  *       maintainability
  *       readability

c/misra/src/rules/RULE-4-12/StdLibDynamicMemoryAllocationUsed.ql renamed to c/misra/src/rules/DIR-4-12/StdLibDynamicMemoryAllocationUsed.ql

@@ -1,13 +1,13 @@
 /**
  * @id c/misra/std-lib-dynamic-memory-allocation-used
- * @name RULE-4-12: Dynamic memory allocation shall not be used
+ * @name DIR-4-12: Dynamic memory allocation shall not be used
  * @description Using dynamic memory allocation and deallocation can result to undefined behavior.
  *              This query is for the Standard Library Implementation. Any implementation outside it
  *              will require a separate query under the same directive.
  * @kind problem
  * @precision very-high
  * @problem.severity error
- * @tags external/misra/id/rule-4-12
+ * @tags external/misra/id/dir-4-12
  *       security
  *       correctness
  *       maintainability

c/misra/src/rules/RULE-4-4/SectionsOfCodeShallNotBeCommentedOut.ql renamed to c/misra/src/rules/DIR-4-4/SectionsOfCodeShallNotBeCommentedOut.ql

@@ -1,11 +1,11 @@
 /**
  * @id c/misra/sections-of-code-shall-not-be-commented-out
- * @name RULE-4-4: Sections of code should not be commented out
+ * @name DIR-4-4: Sections of code should not be commented out
  * @description Commented out code may become out of date leading to developer confusion.
  * @kind problem
  * @precision high
  * @problem.severity warning
- * @tags external/misra/id/rule-4-4
+ * @tags external/misra/id/dir-4-4
  *       maintainability
  *       readability
  *       correctness

c/misra/src/rules/RULE-4-8/ObjectWithNoPointerDereferenceShouldBeOpaque.ql renamed to c/misra/src/rules/DIR-4-8/ObjectWithNoPointerDereferenceShouldBeOpaque.ql

@@ -1,13 +1,13 @@
 /**
  * @id c/misra/object-with-no-pointer-dereference-should-be-opaque
- * @name RULE-4-8: The implementation of an object shall be hidden if a pointer to its structure or union is never dereferenced within a translation unit
+ * @name DIR-4-8: The implementation of an object shall be hidden if a pointer to its structure or union is never dereferenced within a translation unit
  * @description If a pointer to a structure or union is never dereferenced within a translation
  *              unit, then the implementation of the object should be hidden to prevent
  *              unintentional changes.
  * @kind problem
  * @precision very-high
  * @problem.severity error
- * @tags external/misra/id/rule-4-8
+ * @tags external/misra/id/dir-4-8
  *       readability
  *       maintainability
  *       external/misra/obligation/advisory

c/misra/test/rules/RULE-4-10/PrecautionIncludeGuardsNotProvided.testref renamed to c/misra/test/rules/DIR-4-10/PrecautionIncludeGuardsNotProvided.testref

@@ -0,0 +1 @@
+rules/DIR-4-12/StdLibDynamicMemoryAllocationUsed.ql