Refine RULE-21-15

jeongsoolee09 · jeongsoolee09 · commit eca1f2681d2a · 2023-02-17T15:29:37.000-08:00
diff --git a/c/misra/src/rules/RULE-21-15/MemcpyMemmoveMemcmpArgNotPointersToCompatibleTypes.ql b/c/misra/src/rules/RULE-21-15/MemcpyMemmoveMemcmpArgNotPointersToCompatibleTypes.ql
@@ -16,10 +16,13 @@ import codingstandards.c.Pointers
 
 class MemCmpMoveCpy extends Function {
   // Couldn't extend BuiltInFunction because it misses `memcmp`
-  MemCmpMoveCpy() { this.getName().regexpMatch("mem(cmp|cpy|move)") }
+  MemCmpMoveCpy() {
+    this.getName().regexpMatch("mem(cmp|cpy|move)") and
+    this.getADeclaration().getAFile().(HeaderFile).getBaseName() = "string.h"
+  }
 }
 
-query predicate memfunArgTypes(FunctionCall fc, Type dstType, Type srcType) {
+predicate memfunArgTypes(FunctionCall fc, Type dstType, Type srcType) {
   (
     fc.getArgument(0).getUnspecifiedType() instanceof PointerType and
     fc.getArgument(1).getUnspecifiedType() instanceof PointerType

Original file line number	Diff line number	Diff line change
`@@ -16,10 +16,13 @@ import codingstandards.c.Pointers`
`16`	`16`
`17`	`17`	`class MemCmpMoveCpy extends Function {`
`18`	`18`	// Couldn't extend BuiltInFunction because it misses `memcmp`
`19`		`- MemCmpMoveCpy() { this.getName().regexpMatch("mem(cmp\|cpy\|move)") }`
	`19`	`+ MemCmpMoveCpy() {`
	`20`	`+ this.getName().regexpMatch("mem(cmp\|cpy\|move)") and`
	`21`	`+ this.getADeclaration().getAFile().(HeaderFile).getBaseName() = "string.h"`
	`22`	`+ }`
`20`	`23`	`}`
`21`	`24`
`22`		`-query predicate memfunArgTypes(FunctionCall fc, Type dstType, Type srcType) {`
	`25`	`+predicate memfunArgTypes(FunctionCall fc, Type dstType, Type srcType) {`
`23`	`26`	`(`
`24`	`27`	`fc.getArgument(0).getUnspecifiedType() instanceof PointerType and`
`25`	`28`	`fc.getArgument(1).getUnspecifiedType() instanceof PointerType`