Merge branch 'main' into lcartey/scope-performance-fix

Author: knewbury01

change_notes/2024-10-23-cvalue-widening.md

@@ -0,0 +1,2 @@
+ - `M5-0-3`, `M5-0-7`, `M5-0-8`, `M5-0-9` - `CvalueExpressionConvertedToDifferentUnderlyingType.ql`, `ExplicitFloatingIntegralConversionOfACValueExpr.ql`, `ExplicitWideningConversionOfACValueExpr.ql`, `ExplicitSignedness.ql`:
+   - Reduce false positives from misidentifying an explicitly casted expression used as a function argument or return value as a `cvalue`.

cpp/common/test/rules/validcontainerelementaccess/test.cpp

@@ -96,14 +96,14 @@ void f8(const int *ar) {
 void f9(const std::string &s, std::string &str) {
   std::string::iterator loc = str.begin();
   for (auto i = s.begin(), e = s.end(); i != e; ++i, ++loc) { // NON_COMPLIANT
-    str.insert(loc, 'c'); // NON_COMPLIANT[FALSE POSITIVE for str]
+    str.insert(loc, 'c');                                     // NON_COMPLIANT
   }
 }
 
 void f10(const std::string &s, std::string &str) {
   std::string::iterator loc = str.begin();
   for (auto i = s.begin(), e = s.end(); i != e; ++i, ++loc) { // COMPLIANT
-    loc = str.insert(loc, 'c'); // COMPLIANT[FALSE POSITIVE]
+    loc = str.insert(loc, 'c');                               // COMPLIANT
   }
 }