Move PointerOrArrayType into Pointers.qll to deduplicate usage

Author: Nikita Kraiouchkine

c/cert/src/rules/EXP43-C/DoNotPassAlisedPointerToRestrictQualifiedParameter.ql

@@ -17,16 +17,6 @@ import semmle.code.cpp.dataflow.DataFlow
 import semmle.code.cpp.pointsto.PointsTo
 import semmle.code.cpp.rangeanalysis.SimpleRangeAnalysis
 
-/**
- * A type that is a pointer or array type.
- */
-class PointerOrArrayType extends DerivedType {
-  PointerOrArrayType() {
-    this.stripTopLevelSpecifiers() instanceof PointerType or
-    this.stripTopLevelSpecifiers() instanceof ArrayType
-  }
-}
-
 /**
  * A function that has a parameter with a restrict-qualified pointer type.
  */

c/common/src/codingstandards/c/Pointers.qll

@@ -5,6 +5,16 @@
 import cpp
 import codingstandards.cpp.Type
 
+/**
+ * A type that is a pointer or array type.
+ */
+class PointerOrArrayType extends DerivedType {
+  PointerOrArrayType() {
+    this.stripTopLevelSpecifiers() instanceof PointerType or
+    this.stripTopLevelSpecifiers() instanceof ArrayType
+  }
+}
+
 /**
  * An expression which performs pointer arithmetic
  */

c/misra/src/rules/RULE-8-13/PointerShouldPointToConstTypeWhenPossible.ql

@@ -15,15 +15,9 @@
 
 import cpp
 import codingstandards.c.misra
+import codingstandards.c.Pointers
 import codingstandards.cpp.SideEffect
 
-class PointerOrArrayType extends DerivedType {
-  PointerOrArrayType() {
-    this.stripTopLevelSpecifiers() instanceof PointerType or
-    this.stripTopLevelSpecifiers() instanceof ArrayType
-  }
-}
-
 from Variable ptr, PointerOrArrayType type
 where
   not isExcluded(ptr, Pointers1Package::pointerShouldPointToConstTypeWhenPossibleQuery()) and