Convert CTR56-CPP to the new dataflow library

Author: jketema

cpp/cert/src/rules/CTR56-CPP/DoNotUsePointerArithmeticOnPolymorphicObjects.ql

@@ -18,7 +18,7 @@
 
 import cpp
 import codingstandards.cpp.cert
-import semmle.code.cpp.dataflow.DataFlow
+import semmle.code.cpp.dataflow.new.DataFlow
 import NonFinalClassToPointerArithmeticExprFlow::PathGraph
 
 class ArrayAccessOrPointerArith extends Expr {

cpp/cert/test/rules/CTR56-CPP/DoNotUsePointerArithmeticOnPolymorphicObjects.expected

@@ -1,13 +1,11 @@
-WARNING: module 'DataFlow' has been deprecated and may be removed in future (DoNotUsePointerArithmeticOnPolymorphicObjects.ql:46,62-70)
-WARNING: module 'DataFlow' has been deprecated and may be removed in future (DoNotUsePointerArithmeticOnPolymorphicObjects.ql:47,22-30)
-WARNING: module 'DataFlow' has been deprecated and may be removed in future (DoNotUsePointerArithmeticOnPolymorphicObjects.ql:56,20-28)
-WARNING: module 'DataFlow' has been deprecated and may be removed in future (DoNotUsePointerArithmeticOnPolymorphicObjects.ql:62,3-11)
 edges
 | test.cpp:15:19:15:21 | foo | test.cpp:16:24:16:26 | foo | provenance |  |
 | test.cpp:15:19:15:21 | foo | test.cpp:16:51:16:53 | foo | provenance |  |
 | test.cpp:27:19:27:21 | foo | test.cpp:29:18:29:20 | foo | provenance |  |
+| test.cpp:40:12:40:19 | new | test.cpp:40:12:40:19 | new | provenance |  |
 | test.cpp:40:12:40:19 | new | test.cpp:43:6:43:7 | l1 | provenance |  |
 | test.cpp:40:12:40:19 | new | test.cpp:44:6:44:7 | l1 | provenance |  |
+| test.cpp:42:12:42:14 | & ... | test.cpp:42:12:42:14 | & ... | provenance |  |
 | test.cpp:42:12:42:14 | & ... | test.cpp:45:6:45:7 | l3 | provenance |  |
 | test.cpp:42:12:42:14 | & ... | test.cpp:46:6:46:7 | l3 | provenance |  |
 | test.cpp:43:6:43:7 | l1 | test.cpp:15:19:15:21 | foo | provenance |  |
@@ -21,6 +19,8 @@ nodes
 | test.cpp:27:19:27:21 | foo | semmle.label | foo |
 | test.cpp:29:18:29:20 | foo | semmle.label | foo |
 | test.cpp:40:12:40:19 | new | semmle.label | new |
+| test.cpp:40:12:40:19 | new | semmle.label | new |
+| test.cpp:42:12:42:14 | & ... | semmle.label | & ... |
 | test.cpp:42:12:42:14 | & ... | semmle.label | & ... |
 | test.cpp:43:6:43:7 | l1 | semmle.label | l1 |
 | test.cpp:44:6:44:7 | l1 | semmle.label | l1 |