C++: Remove unnamed and specialization types

Author: lcartey

cpp/common/src/ext/stdcpp14.generated.names.model.yml

@@ -52,7 +52,6 @@ extensions:
   - [C++14, atomic, std, atomic_char]
   - [C++14, atomic, std, atomic_bool]
   - [C++14, thread, std, thread]
-  - [C++14, thread, std, hash]
   - [C++14, thread, std, id]
   - [C++14, thread, std, native_handle_type]
   - [C++14, initializer_list, std, value_type]
@@ -65,7 +64,6 @@ extensions:
   - [C++14, iterator, std, value_type]
   - [C++14, iterator, std, reference]
   - [C++14, iterator, std, iterator]
-  - [C++14, iterator, std, (unnamed enum)]
   - [C++14, iterator, std, iterator_category]
   - [C++14, iterator, std, random_access_iterator_tag]
   - [C++14, iterator, std, bidirectional_iterator_tag]
@@ -85,7 +83,6 @@ extensions:
   - [C++14, iterator, std, istream_type]
   - [C++14, iterator, std, streambuf_type]
   - [C++14, iterator, std, iterator_traits]
-  - [C++14, random, std, (unnamed class/struct/union)]
   - [C++14, random, std, param_type]
   - [C++14, random, std, distribution_type]
   - [C++14, random, std, result_type]
@@ -132,7 +129,6 @@ extensions:
   - [C++14, exception, std, unexpected_handler]
   - [C++14, exception, std, terminate_handler]
   - [C++14, exception, 'std::__exception_ptr', exception_ptr]
-  - [C++14, locale, std, (unnamed enum)]
   - [C++14, locale, std, int_type]
   - [C++14, locale, std, state_type]
   - [C++14, locale, std, char_type]
@@ -193,9 +189,7 @@ extensions:
   - [C++14, set, std, key_compare]
   - [C++14, set, std, multiset]
   - [C++14, bitset, std, reference]
-  - [C++14, bitset, std, hash]
   - [C++14, bitset, std, bitset]
-  - [C++14, system_error, std, hash]
   - [C++14, system_error, std, errc]
   - [C++14, system_error, std, is_error_condition_enum]
   - [C++14, system_error, std, system_error]
@@ -265,7 +259,6 @@ extensions:
   - [C++14, deque, std, reference]
   - [C++14, deque, std, size_type]
   - [C++14, deque, std, iterator]
-  - [C++14, deque, std, (unnamed enum)]
   - [C++14, deque, std, iterator_category]
   - [C++14, deque, std, pointer]
   - [C++14, deque, std, difference_type]
@@ -289,7 +282,6 @@ extensions:
   - [C++14, future, std, value_type]
   - [C++14, future, std, pointer]
   - [C++14, future, std, result_type]
-  - [C++14, future, std, is_error_code_enum]
   - [C++14, future, std, packaged_task]
   - [C++14, future, std, promise]
   - [C++14, future, std, shared_future]
@@ -339,7 +331,6 @@ extensions:
   - [C++14, vector, std, reference]
   - [C++14, vector, std, size_type]
   - [C++14, vector, std, iterator]
-  - [C++14, vector, std, (unnamed enum)]
   - [C++14, vector, std, pointer]
   - [C++14, vector, std, difference_type]
   - [C++14, vector, std, reverse_iterator]
@@ -494,15 +485,13 @@ extensions:
   - [C++14, streambuf, std, pos_type]
   - [C++14, streambuf, std, traits_type]
   - [C++14, streambuf, std, basic_streambuf]
-  - [C++14, ios, std, (unnamed enum)]
   - [C++14, ios, std, streamoff]
   - [C++14, ios, std, int_type]
   - [C++14, ios, std, off_type]
   - [C++14, ios, std, char_type]
   - [C++14, ios, std, pos_type]
   - [C++14, ios, std, ios_base]
   - [C++14, ios, std, traits_type]
-  - [C++14, ios, std, is_error_code_enum]
   - [C++14, ios, std, Init]
   - [C++14, ios, std, failure]
   - [C++14, ios, std, event_callback]
@@ -519,13 +508,11 @@ extensions:
   - [C++14, ios, std, streampos]
   - [C++14, string, std, type]
   - [C++14, string, std, value_type]
-  - [C++14, string, std, (unnamed class/struct/union)]
   - [C++14, string, std, const_iterator]
   - [C++14, string, std, const_reference]
   - [C++14, string, std, reference]
   - [C++14, string, std, size_type]
   - [C++14, string, std, iterator]
-  - [C++14, string, std, (unnamed enum)]
   - [C++14, string, std, iterator_category]
   - [C++14, string, std, pointer]
   - [C++14, string, std, difference_type]
@@ -545,7 +532,6 @@ extensions:
   - [C++14, string, std, char_type]
   - [C++14, string, std, pos_type]
   - [C++14, string, std, allocator_type]
-  - [C++14, string, std, hash]
   - [C++14, string, std, basic_string]
   - [C++14, string, std, traits_type]
   - [C++14, string, std, basic_stringbuf]
@@ -628,7 +614,6 @@ extensions:
   - [C++14, type_traits, std, remove_volatile_t]
   - [C++14, type_traits, std, remove_const_t]
   - [C++14, type_traits, std, value_type]
-  - [C++14, type_traits, std, (unnamed class/struct/union)]
   - [C++14, type_traits, std, is_signed]
   - [C++14, type_traits, std, false_type]
   - [C++14, type_traits, std, true_type]
@@ -818,7 +803,6 @@ extensions:
   - [C++14, typeinfo, std, type_info]
   - [C++14, typeinfo, std, bad_typeid]
   - [C++14, typeinfo, std, bad_cast]
-  - [C++14, algorithm, std, (unnamed enum)]
   - [C++14, iosfwd, std, fpos]
   - [C++14, iosfwd, std, streamsize]
   - [C++14, iosfwd, std, streamoff]
@@ -852,8 +836,6 @@ extensions:
   - [C++14, iosfwd, std, u32streampos]
   - [C++14, iosfwd, std, u16streampos]
   - [C++14, iosfwd, std, wstreampos]
-  - [C++14, cmath, std, (unnamed enum)]
-  - [C++14, stdexcept, std, (unnamed class/struct/union)]
   - [C++14, stdexcept, std, invalid_argument]
   - [C++14, stdexcept, std, underflow_error]
   - [C++14, stdexcept, std, overflow_error]
@@ -872,7 +854,6 @@ extensions:
   - [C++14, memory, std, reference]
   - [C++14, memory, std, size_type]
   - [C++14, memory, std, iterator]
-  - [C++14, memory, std, (unnamed enum)]
   - [C++14, memory, std, pointer]
   - [C++14, memory, std, difference_type]
   - [C++14, memory, std, element_type]
@@ -908,7 +889,6 @@ extensions:
   - [C++14, memory, std, allocator_traits]
   - [C++14, typeindex, std, result_type]
   - [C++14, typeindex, std, argument_type]
-  - [C++14, typeindex, std, hash]
   - [C++14, typeindex, std, type_index]
 - addsTo: {extensible: libraryFunctionModel, pack: codeql/common-cpp-coding-standards}
   data:

scripts/generate_standard_library_models/cpp/queries/libraryTypeModel.ql

@@ -9,6 +9,10 @@ where
   // includes types outside the C/C++ standard library.
   declInVisibleStdNamespace(t) and
   // Do not report types from template instantiations - instead report the uninstantiated template
-  not t.isFromTemplateInstantiation(_)
+  not t.isFromTemplateInstantiation(_) and
+  // Ignore full tempalte specializations (partial specializations are fine)
+  not t instanceof FullClassTemplateSpecialization and
+  // Remove unnamed types, because they do not have a reserved name
+  not t.isAnonymous()
 select getStandard(), getAClosestStandardLibraryHeader(t.getFile()).getBaseName(),
   getVisibleNamespaceString(t.getNamespace()), t.getSimpleName()