M5-2-2: Make into shared query

This shared implementation will be used for implementing MISRA C++
2023 8.2.1.

Author: lcartey

cpp/autosar/src/rules/M5-2-2/PointerToAVirtualBaseClassCastToAPointer.ql

@@ -15,14 +15,10 @@
 
 import cpp
 import codingstandards.cpp.autosar
+import codingstandards.cpp.rules.pointertoavirtualbaseclasscasttoapointer.PointerToAVirtualBaseClassCastToAPointer
 
-from Cast cast, VirtualBaseClass castFrom, Class castTo
-where
-  not isExcluded(cast, PointersPackage::pointerToAVirtualBaseClassCastToAPointerQuery()) and
-  not cast instanceof DynamicCast and
-  castFrom = cast.getExpr().getType().(PointerType).getBaseType() and
-  cast.getType().(PointerType).getBaseType() = castTo and
-  castTo = castFrom.getADerivedClass+()
-select cast,
-  "A pointer to virtual base class $@ is not cast to a pointer of derived class $@ using a dynamic_cast.",
-  castFrom, castFrom.getName(), castTo, castTo.getName()
+class PointerToAVirtualBaseClassCastToAPointerQuery extends PointerToAVirtualBaseClassCastToAPointerSharedQuery {
+  PointerToAVirtualBaseClassCastToAPointerQuery() {
+    this = PointersPackage::pointerToAVirtualBaseClassCastToAPointerQuery()
+  }
+}

cpp/autosar/test/rules/M5-2-2/PointerToAVirtualBaseClassCastToAPointer.qlref

@@ -0,0 +1,26 @@
+/**
+ * Provides a library with a `problems` predicate for the following issue:
+ * A pointer to a virtual base class shall only be cast to a pointer to a derived class
+ * by means of dynamic_cast, otherwise the cast has undefined behavior.
+ */
+
+import cpp
+import codingstandards.cpp.Customizations
+import codingstandards.cpp.Exclusions
+
+abstract class PointerToAVirtualBaseClassCastToAPointerSharedQuery extends Query { }
+
+Query getQuery() { result instanceof PointerToAVirtualBaseClassCastToAPointerSharedQuery }
+
+query predicate problems(Cast cast, string message) {
+  exists(VirtualBaseClass castFrom, Class castTo |
+    not isExcluded(cast, getQuery()) and
+    not cast instanceof DynamicCast and
+    castFrom = cast.getExpr().getType().(PointerType).getBaseType() and
+    cast.getType().(PointerType).getBaseType() = castTo and
+    castTo = castFrom.getADerivedClass+() and
+    message =
+      "A pointer to virtual base class " + castFrom.getName() +
+        " is not cast to a pointer of derived class " + castTo.getName() + " using a dynamic_cast."
+  )
+}

cpp/common/src/codingstandards/cpp/rules/pointertoavirtualbaseclasscasttoapointer/PointerToAVirtualBaseClassCastToAPointer.qll

@@ -0,0 +1,4 @@
+// GENERATED FILE - DO NOT MODIFY
+import codingstandards.cpp.rules.pointertoavirtualbaseclasscasttoapointer.PointerToAVirtualBaseClassCastToAPointer
+
+class TestFileQuery extends PointerToAVirtualBaseClassCastToAPointerSharedQuery, TestQuery { }

cpp/autosar/test/rules/M5-2-2/PointerToAVirtualBaseClassCastToAPointer.expected renamed to cpp/common/test/rules/pointertoavirtualbaseclasscasttoapointer/PointerToAVirtualBaseClassCastToAPointer.expected

@@ -306,7 +306,8 @@
           "short_name": "PointerToAVirtualBaseClassCastToAPointer",
           "tags": [
             "correctness"
-          ]
+          ],
+          "shared_implementation_short_name": "PointerToAVirtualBaseClassCastToAPointer"
         }
       ],
       "title": "A pointer to a virtual base class shall only be cast to a pointer to a derived class by means of dynamic_cast."