Merge pull request #62 from mbaluda-org/issue11-A13-2-2

Issue 11: A13-2-2 distinguish stream operators from binary shift

Author: lcartey

change_notes/2022-08-17-fix-reported-fp-for-a13-2-2.md

@@ -0,0 +1,2 @@
+ - `A13-2-2` - `BinaryOperatorAndBitwiseOperatorReturnAPrvalue.ql`:
+   -  Remove findings related to stream operators.

cpp/autosar/test/rules/A13-2-2/BinaryOperatorAndBitwiseOperatorReturnAPrvalue.expected

@@ -1,3 +1,4 @@
 | test.cpp:16:9:16:17 | operator- | User-defined bitwise or arithmetic operator operator-(const A &, int) -> const A does not return a prvalue. |
 | test.cpp:20:4:20:12 | operator\| | User-defined bitwise or arithmetic operator operator\|(const A &, const A &) -> A * does not return a prvalue. |
-| test.cpp:29:6:29:14 | operator+ | User-defined bitwise or arithmetic operator NS_C::operator+(const C &, const C &) -> int & does not return a prvalue. |
+| test.cpp:24:9:24:18 | operator<< | User-defined bitwise or arithmetic operator operator<<(const A &, const A &) -> const A does not return a prvalue. |
+| test.cpp:34:6:34:14 | operator+ | User-defined bitwise or arithmetic operator NS_C::operator+(const C &, const C &) -> int & does not return a prvalue. |

cpp/autosar/test/rules/A13-2-2/test.cpp

@@ -21,6 +21,11 @@ A *operator|(A const &a1, A const &a2) noexcept { // NON_COMPLIANT
   return new A();
 }
 
+const A operator<<(A const &, A const &) noexcept // NON_COMPLIANT
+{
+  return A{};
+}
+
 class C {
   C &operator=(const C &rhs);
 };
@@ -31,3 +36,10 @@ int &operator+(const C &lhs, const C &rhs) { // NON_COMPLIANT
   return slocal;
 }
 } // namespace NS_C
+
+#include <iostream>
+struct Test {};
+std::ostream &operator<<(std::ostream &os, const Test &) { // COMPLIANT
+  os << "test";
+  return os;
+}

cpp/common/src/codingstandards/cpp/Operator.qll

@@ -170,8 +170,8 @@ class UserBitwiseOperator extends Function {
       op in ["&", "|", "^", "~", "%", "<<", ">>"]
     ) and
     not this.isCompilerGenerated() and
-    not this.getType().hasName("ostream") and
-    not this.getType().hasName("istream")
+    not this.getType().(ReferenceType).getBaseType().hasName("ostream") and
+    not this.getType().(ReferenceType).getBaseType().hasName("istream")
   }
 }
 

cpp/common/test/includes/standard-library/ostream.h

@@ -1,6 +1,7 @@
 #ifndef _GHLIBCPP_OSTREAM
 #define _GHLIBCPP_OSTREAM
 #include "string.h"
+#include <ios>
 
 namespace std {
 template <class charT, class traits>