refactor query

Author: jsinglet

cpp/autosar/src/rules/M7-4-1/UsageOfAssemblerNotDocumented.ql

@@ -17,10 +17,10 @@
 
 import cpp
 import codingstandards.cpp.autosar
+import codingstandards.cpp.rules.usageofassemblernotdocumented.UsageOfAssemblerNotDocumented
 
-from AsmStmt a
-where
-  not isExcluded(a, BannedLibrariesPackage::usageOfAssemblerNotDocumentedQuery()) and
-  not exists(Comment c | c.getCommentedElement() = a) and
-  not a.isAffectedByMacro()
-select a, "Use of assembler is not documented."
+class UsageOfAssemblerNotDocumentedQuery extends UsageOfAssemblerNotDocumentedSharedQuery {
+  UsageOfAssemblerNotDocumentedQuery() {
+    this = BannedLibrariesPackage::usageOfAssemblerNotDocumentedQuery()
+  }
+}

cpp/autosar/test/rules/M7-4-1/UsageOfAssemblerNotDocumented.qlref

@@ -0,0 +1 @@
+cpp/common/test/rules/usageofassemblernotdocumented/UsageOfAssemblerNotDocumented.ql

cpp/autosar/test/rules/M7-4-1/UsageOfAssemblerNotDocumented.testref

@@ -0,0 +1,19 @@
+/**
+ * Provides a library which includes a `problems` predicate for reporting
+ * undocumented uses of assembly.
+ */
+
+import cpp
+import codingstandards.cpp.Customizations
+import codingstandards.cpp.Exclusions
+
+abstract class UsageOfAssemblerNotDocumentedSharedQuery extends Query { }
+
+Query getQuery() { result instanceof UsageOfAssemblerNotDocumentedSharedQuery }
+
+query predicate problems(AsmStmt a, string message) {
+  not isExcluded(a, getQuery()) and
+  not exists(Comment c | c.getCommentedElement() = a) and
+  not a.isAffectedByMacro() and
+  message = "Use of assembler is not documented."
+}

cpp/common/src/codingstandards/cpp/rules/usageofassemblernotdocumented/UsageOfAssemblerNotDocumented.qll

@@ -0,0 +1,2 @@
+// GENERATED FILE - DO NOT MODIFY
+import codingstandards.cpp.rules.usageofassemblernotdocumented.UsageOfAssemblerNotDocumented

cpp/autosar/test/rules/M7-4-1/UsageOfAssemblerNotDocumented.expected renamed to cpp/common/test/rules/usageofassemblernotdocumented/UsageOfAssemblerNotDocumented.expected

@@ -229,6 +229,7 @@
           "precision": "very-high",
           "severity": "recommendation",
           "short_name": "UsageOfAssemblerNotDocumented",
+          "shared_implementation_short_name": "UsageOfAssemblerNotDocumented",
           "tags": [
             "readability",
             "maintainability",