Fix for M0-1-4's testcase failures

Author: rak3-sh

cpp/autosar/src/rules/M0-1-3/UnusedLocalVariable.ql

@@ -56,5 +56,13 @@ where
   not isExcluded(v, DeadCodePackage::unusedLocalVariableQuery()) and
   // Local variable is never accessed
   not exists(v.getAnAccess()) and
+  // Sometimes multiple objects representing the same entities are created in
+  // the AST. Check if those are not accessed as well. Refer issue #658
+  not exists(LocalScopeVariable another |
+    another.getDefinitionLocation() = v.getDefinitionLocation() and
+    another.hasName(v.getName()) and
+    exists(another.getAnAccess()) and
+    another != v
+  ) and
   getUseCountConservatively(v) = 0
 select v, "Local variable '" + v.getName() + "' in '" + v.getFunction().getName() + "' is not used."

cpp/common/src/codingstandards/cpp/deadcode/UnusedVariables.qll

@@ -52,12 +52,7 @@ class PotentiallyUnusedLocalVariable extends LocalVariable {
     // exclude uninstantiated template members
     not this.isFromUninstantiatedTemplate(_) and
     // Do not report compiler generated variables
-    not this.isCompilerGenerated() and
-    not exists(LocalScopeVariable another |
-      another.getDefinitionLocation() = this.getDefinitionLocation() and
-      another.hasName(this.getName()) and
-      exists(another.getAnAccess())
-    )
+    not this.isCompilerGenerated()
   }
 }