checkpoint

Author: jeongsoolee09

c/misra/src/rules/RULE-21-13/CtypeFunctionArgNotUnsignedCharOrEof.ql

@@ -14,30 +14,34 @@ import cpp
 import codingstandards.c.misra
 import codingstandards.cpp.ReadErrorsAndEOF
 import semmle.code.cpp.rangeanalysis.SimpleRangeAnalysis
-import semmle.code.cpp.rangeanalysis.RangeAnalysisUtils
 
+//import semmle.code.cpp.rangeanalysis.RangeAnalysisUtils
 class CtypeFunction extends Function {
   CtypeFunction() { this.getADeclaration().getAFile().(HeaderFile).getBaseName() = "ctype.h" }
 }
 
+/* TODO Under construction */
 from FunctionCall ctypeCall
 where
   not isExcluded(ctypeCall,
-    StandardLibraryFunctionTypesPackage::ctypeFunctionArgNotUnsignedCharOrEofQuery()) and
-  not exists(CtypeFunction ctype, UnsignedCharType unsignedChar |
-    ctypeCall = ctype.getACallToThisFunction()
-  |
-    /* Case 1: The argument's value should be in the `unsigned char` range. */
-    // Use `.getExplicitlyConverted` to consider inline argument casts.
-    typeLowerBound(unsignedChar) <= lowerBound(ctypeCall.getAnArgument().getExplicitlyConverted()) and
-    upperBound(ctypeCall.getAnArgument().getExplicitlyConverted()) <= typeUpperBound(unsignedChar)
-    or
-    /* Case 2: EOF flows to this argument without modifications. */
-    exists(EOFInvocation eof |
-      DataFlow::localFlow(DataFlow::exprNode(eof.getExpr()),
-        DataFlow::exprNode(ctypeCall.getAnArgument()))
-    )
-  )
-select ctypeCall,
-  "The <ctype.h> function " + ctypeCall + " accepts an argument " +
-    ctypeCall.getAnArgument().toString() + " that is not an unsigned char nor an EOF."
+    StandardLibraryFunctionTypesPackage::ctypeFunctionArgNotUnsignedCharOrEofQuery())
+//    and
+// not exists(CtypeFunction ctype, Expr ctypeCallArgument |
+//   ctype = ctypeCall.getTarget() and
+//   ctypeCallArgument = ctypeCall.getAnArgument().getExplicitlyConverted()
+// |
+//   /* Case 1: The argument's value should be in the `unsigned char` range. */
+//   // Use `.getExplicitlyConverted` to consider inline argument casts.
+//   -1 <= lowerBound(ctypeCallArgument) and
+//   upperBound(ctypeCallArgument) <= 255
+//   or
+//   /* Case 2: EOF flows to this argument without modifications. */
+//   exists(EOFInvocation eof |
+//     DataFlow::localFlow(DataFlow::exprNode(eof.getExpr()), DataFlow::exprNode(ctypeCallArgument))
+//   )
+// )
+select ctypeCall.getAnArgument(), lowerBound(ctypeCall.getAnArgument()),
+  upperBound(ctypeCall.getAnArgument())
+// select ctypeCall,
+//   "The <ctype.h> function " + ctypeCall + " accepts an argument " +
+//     ctypeCall.getAnArgument().toString() + " that is not an unsigned char nor an EOF."