Move definition to Operator.qll

Author: lcartey

cpp/autosar/src/rules/M5-3-3/UnaryOperatorOverloaded.ql

@@ -13,14 +13,8 @@
 
 import cpp
 import codingstandards.cpp.autosar
+import codingstandards.cpp.Operator
 
-from Operator o
-where
-  not isExcluded(o, OperatorsPackage::unaryOperatorOverloadedQuery()) and
-  o.hasName("operator&") and
-  (
-    if o instanceof MemberFunction
-    then o.getNumberOfParameters() = 0
-    else o.getNumberOfParameters() = 1
-  )
+from UnaryAddressOfOperator o
+where not isExcluded(o, OperatorsPackage::unaryOperatorOverloadedQuery())
 select o, "The unary & operator overloaded."

cpp/common/src/codingstandards/cpp/Operator.qll

@@ -264,3 +264,19 @@ class UserOverloadedOperator extends Function {
     not this.isCompilerGenerated()
   }
 }
+
+/** A user defined operator address of operator (`&`). */
+class UnaryAddressOfOperator extends Operator {
+  UnaryAddressOfOperator() {
+    hasName("operator&") and
+    (
+      // If this is a member function, it needs to have zero arguments to be the unary addressof
+      // operator
+      if this instanceof MemberFunction
+      then getNumberOfParameters() = 0
+      else
+        // Otherwise it needs one argument to be unary
+        getNumberOfParameters() = 1
+    )
+  }
+}