Add first draft of ForRangeInitializerAtMostOneFunctionCall

Author: jeongsoolee09

cpp/misra/src/rules/RULE-9-5-2/ForRangeInitializerAtMostOneFunctionCall.ql

@@ -19,7 +19,9 @@
 import cpp
 import codingstandards.cpp.misra
 
-from
+from RangeBasedForStmt foreach, string message
 where
-  not isExcluded(x, StatementsPackage::forRangeInitializerAtMostOneFunctionCallQuery()) and
-select
+  not isExcluded(foreach, StatementsPackage::forRangeInitializerAtMostOneFunctionCallQuery()) and
+  count(Call call | call = foreach.getRange().getAChild*() | call) >= 2 and
+  message = "has nested call expression in its initializer"
+select foreach, "Range-based for loop " + message + "."

cpp/misra/test/rules/RULE-9-5-2/ForRangeInitializerAtMostOneFunctionCall.expected

@@ -1 +1,8 @@
-No expected results have yet been specified
+| test.cpp:48:3:49:3 | for(...:...) ... | Range-based for loop has nested call expression in its initializer. |
+| test.cpp:56:3:59:3 | for(...:...) ... | Range-based for loop has nested call expression in its initializer. |
+| test.cpp:71:3:73:3 | for(...:...) ... | Range-based for loop has nested call expression in its initializer. |
+| test.cpp:95:3:97:3 | for(...:...) ... | Range-based for loop has nested call expression in its initializer. |
+| test.cpp:99:3:101:3 | for(...:...) ... | Range-based for loop has nested call expression in its initializer. |
+| test.cpp:103:3:107:3 | for(...:...) ... | Range-based for loop has nested call expression in its initializer. |
+| test.cpp:116:3:119:3 | for(...:...) ... | Range-based for loop has nested call expression in its initializer. |
+| test.cpp:121:3:124:3 | for(...:...) ... | Range-based for loop has nested call expression in its initializer. |

cpp/misra/test/rules/RULE-9-5-2/test.cpp

@@ -1,5 +1,5 @@
-#include <vector>
 #include <array>
+#include <vector>
 
 /* Helper functions */
 std::vector<int> getData() { return {1, 2, 3}; }
@@ -10,8 +10,8 @@ class MyContainer {
 public:
   MyContainer() = default;
   MyContainer(std::vector<int> data) : data_(data) {}
-  std::vector<int>::const_iterator begin() const { return data_.begin(); }
-  std::vector<int>::const_iterator end() const { return data_.end(); }
+  std::vector<int>::iterator begin() { return data_.begin(); }
+  std::vector<int>::iterator end() { return data_.end(); }
 
 private:
   std::vector<int> data_{7, 8, 9};
@@ -20,15 +20,16 @@ class MyContainer {
 class ConvertibleToVector {
 public:
   operator std::vector<int>() const { return {7, 8, 9}; }
-  std::array<int, 3>::const_iterator begin() const { return data_.begin(); }
-  std::array<int, 3>::const_iterator end() const { return data_.end(); }
+  std::array<int, 3>::iterator begin() { return data_.begin(); }
+  std::array<int, 3>::iterator end() { return data_.end(); }
+  std::array<int, 3>::const_iterator begin() const { return data_.cbegin(); }
+  std::array<int, 3>::const_iterator end() const { return data_.cend(); }
 
 private:
   std::array<int, 3> data_{7, 8, 9};
 };
 
-std::vector<int> operator+(std::vector<int> a,
-                           std::vector<int> b) {
+std::vector<int> operator+(std::vector<int> a, std::vector<int> b) {
   std::vector<int> result = a;
   result.insert(result.end(), b.begin(), b.end());
   return result;
@@ -49,8 +50,12 @@ int main() {
 
   /* ========== 2. OBJECT CREATION (CONSTRUCTOR CALLS) ========== */
 
+  for (auto x : std::vector<int>(3)) { // COMPLIANT: 1 constructor call only
+  }
+
   for (auto x :
-       std::vector<int>{1, 2, 3}) { // COMPLIANT: 1 constructor call only
+       std::vector<int>{1, 2, 3}) { // NON_COMPLIANT: 2 constructor call to
+                                    // `vector` and `initializer_list`, respectively
   }
 
   for (auto x : MyContainer()) { // COMPLIANT: 1 constructor call only
@@ -77,12 +82,22 @@ int main() {
 
   /* ========== 3. OPERATOR OVERLOADING ========== */
 
+  std::vector<int> vec1 = {1}, vec2 = {2}, vec3 = {3};
+  std::vector<int> appendedVector = (vec1 + vec2) + vec3;
+  for (auto x : appendedVector) { // COMPLIANT: 0 calls
+  }
+
+  std::vector<int> appendedVector2 = getData() + processData(localVec);
+  for (auto x : appendedVector2) { // COMPLIANT: 0 calls
+  }
+
   std::vector<int> anotherVec = {4, 5, 6};
-  for (auto x : localVec + anotherVec) { // COMPLIANT: 1 operator+ call only
+  for (auto x : localVec + anotherVec) { // NON_COMPLIANT: 2 calls to vector's
+                                         // constructor, 1 operator+ call
   }
 
-  std::vector<int> vec1 = {1}, vec2 = {2}, vec3 = {3};
-  for (auto x : (vec1 + vec2) + vec3) { // NON-COMPLIANT: 2 operator+ calls
+  for (auto x : (vec1 + vec2) + vec3) { // NON-COMPLIANT: 3 calls to vector's
+                                        // constructor, 2 operator+ calls
   }
 
   for (auto x :
@@ -91,18 +106,11 @@ int main() {
                localVec)) { // NON-COMPLIANT: 2 function calls + 1 operator call
   }
 
-  std::vector<int> appendedVector = (vec1 + vec2) + vec3;
-  for (auto x : appendedVector) { // COMPLIANT: 0 calls
-  }
-
-  std::vector<int> appendedVector2 = getData() + processData(localVec);
-  for (auto x : appendedVector2) { // COMPLIANT: 0 calls
-  }
-
   /* ========== 4. IMPLICIT CONVERSIONS ========== */
 
   ConvertibleToVector convertible;
-  for (int x : convertible) { // COMPLIANT: 1 conversion operator call only
+  for (int x :
+       ConvertibleToVector()) { // COMPLIANT: 1 conversion operator call only
   }
 
   for (int x :
@@ -116,12 +124,10 @@ int main() {
   }
 
   std::vector<int> intVector1 = convertToIntVector(convertible);
-  for (int x : intVector1) { // NON_COMPLIANT: 1 function call + 1
-                              // conversion operator call
+  for (int x : intVector1) { // COMPLIANT: 0 function calls
   }
 
   std::vector<int> intVector2 = convertToIntVector(convertible);
-  for (int x : intVector2) { // NON_COMPLIANT: 1 function call + 1
-                              // conversion operator call
+  for (int x : intVector2) { // COMPLIANT: 0 function calls
   }
 }